[Qemu-devel] [BUG] need to export variables in config.mak

[Qemu-devel] [BUG] need to export variables in config.mak

[Chris Friesen]

We've been playing a bit with kvm-kmod-3.0b.  We use a cross compile environment, and one of my coworkers noticed that the variables in config.mak weren't actually exported and so didn't actually have any effect.

I think something like the following patch is required.

Thanks,
Chris Friesen



Index: kvm-kmod-3.0b/configure
===================================================================
--- kvm-kmod-3.0b.orig/configure	2011-09-27 15:12:08.000009000 -0500
+++ kvm-kmod-3.0b/configure	2011-09-27 15:11:59.001566000 -0500
@@ -168,24 +168,24 @@ fi
 rm -f include/asm include-compat/asm
 mkdir -p include
 ln -sf asm-"$karch" include/asm
 ln -sf asm-"$karch" include-compat/asm
 
 cat <<EOF > config.mak
-ARCH=$arch
-PROCESSOR=$processor
-PREFIX=$prefix
-KERNELDIR=$kerneldir
-KERNELSOURCEDIR=$kernelsourcedir
-KERNELVERSION=$kernel_version_str
-CROSS_COMPILE=$cross_prefix
-CC=$cross_prefix$cc
-LD=$cross_prefix$ld
-OBJCOPY=$cross_prefix$objcopy
-AR=$cross_prefix$ar
-KVM_VERSION=$(kvm_version)
+export ARCH=$arch
+export PROCESSOR=$processor
+export PREFIX=$prefix
+export KERNELDIR=$kerneldir
+export KERNELSOURCEDIR=$kernelsourcedir
+export KERNELVERSION=$kernel_version_str
+export CROSS_COMPILE=$cross_prefix
+export CC=$cross_prefix$cc
+export LD=$cross_prefix$ld
+export OBJCOPY=$cross_prefix$objcopy
+export AR=$cross_prefix$ar
+export KVM_VERSION=$(kvm_version)
 EOF
 
 cat <<EOF > kvm-kmod-config.h
 #define KERNEL_EXTRAVERSION $kernel_extraversion
 $config_fedora_kernel
 EOF








-- 
Chris Friesen
Software Developer
GENBAND
chris.friesen@genband.com
www.genband.com

Re: [Qemu-devel] [BUG] need to export variables in config.mak

[Jan Kiszka]

On 2011-09-30 19:07, Chris Friesen wrote:
> We've been playing a bit with kvm-kmod-3.0b.  We use a cross compile environment, and one of my coworkers noticed that the variables in config.mak weren't actually exported and so didn't actually have any effect.
> 
> I think something like the following patch is required.

If you can confirm that they have the right effect and put a signed-off
+ description to the patch, I'll merge it.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

[Qemu-devel] [PATCH] need to export variables in config.mak

[Chris Friesen]

The variables being written to config.mak by configure
need to be exported in order to take effect when building
the package.

The following patch fixes this in our environment.

Signed-off-by: Chris Friesen <chris.friesen@genband.com>


Index: kvm-kmod-3.0b/configure
===================================================================
--- kvm-kmod-3.0b.orig/configure	2011-09-27 15:12:08.000009000 -0500
+++ kvm-kmod-3.0b/configure	2011-09-27 15:11:59.001566000 -0500
@@ -168,24 +168,24 @@ fi
 rm -f include/asm include-compat/asm
 mkdir -p include
 ln -sf asm-"$karch" include/asm
 ln -sf asm-"$karch" include-compat/asm
 
 cat <<EOF > config.mak
-ARCH=$arch
-PROCESSOR=$processor
-PREFIX=$prefix
-KERNELDIR=$kerneldir
-KERNELSOURCEDIR=$kernelsourcedir
-KERNELVERSION=$kernel_version_str
-CROSS_COMPILE=$cross_prefix
-CC=$cross_prefix$cc
-LD=$cross_prefix$ld
-OBJCOPY=$cross_prefix$objcopy
-AR=$cross_prefix$ar
-KVM_VERSION=$(kvm_version)
+export ARCH=$arch
+export PROCESSOR=$processor
+export PREFIX=$prefix
+export KERNELDIR=$kerneldir
+export KERNELSOURCEDIR=$kernelsourcedir
+export KERNELVERSION=$kernel_version_str
+export CROSS_COMPILE=$cross_prefix
+export CC=$cross_prefix$cc
+export LD=$cross_prefix$ld
+export OBJCOPY=$cross_prefix$objcopy
+export AR=$cross_prefix$ar
+export KVM_VERSION=$(kvm_version)
 EOF
 
 cat <<EOF > kvm-kmod-config.h
 #define KERNEL_EXTRAVERSION $kernel_extraversion
 $config_fedora_kernel
 EOF





-- 
Chris Friesen
Software Developer
GENBAND
chris.friesen@genband.com
www.genband.com

Re: [Qemu-devel] [PATCH] need to export variables in config.mak

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]

On 2011-09-30 19:40, Chris Friesen wrote:
> The variables being written to config.mak by configure
> need to be exported in order to take effect when building
> the package.
> 
> The following patch fixes this in our environment.
> 
> Signed-off-by: Chris Friesen <chris.friesen@genband.com>
> 
> 
> Index: kvm-kmod-3.0b/configure
> ===================================================================
> --- kvm-kmod-3.0b.orig/configure	2011-09-27 15:12:08.000009000 -0500
> +++ kvm-kmod-3.0b/configure	2011-09-27 15:11:59.001566000 -0500
> @@ -168,24 +168,24 @@ fi
>  rm -f include/asm include-compat/asm
>  mkdir -p include
>  ln -sf asm-"$karch" include/asm
>  ln -sf asm-"$karch" include-compat/asm
>  
>  cat <<EOF > config.mak
> -ARCH=$arch
> -PROCESSOR=$processor
> -PREFIX=$prefix
> -KERNELDIR=$kerneldir
> -KERNELSOURCEDIR=$kernelsourcedir
> -KERNELVERSION=$kernel_version_str
> -CROSS_COMPILE=$cross_prefix
> -CC=$cross_prefix$cc
> -LD=$cross_prefix$ld
> -OBJCOPY=$cross_prefix$objcopy
> -AR=$cross_prefix$ar
> -KVM_VERSION=$(kvm_version)
> +export ARCH=$arch
> +export PROCESSOR=$processor
> +export PREFIX=$prefix
> +export KERNELDIR=$kerneldir
> +export KERNELSOURCEDIR=$kernelsourcedir
> +export KERNELVERSION=$kernel_version_str
> +export CROSS_COMPILE=$cross_prefix
> +export CC=$cross_prefix$cc
> +export LD=$cross_prefix$ld
> +export OBJCOPY=$cross_prefix$objcopy
> +export AR=$cross_prefix$ar
> +export KVM_VERSION=$(kvm_version)
>  EOF
>  
>  cat <<EOF > kvm-kmod-config.h
>  #define KERNEL_EXTRAVERSION $kernel_extraversion
>  $config_fedora_kernel
>  EOF
> 

Thanks, merged. I just dropped the export from those variables that are
kvm-kmod-only.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

Re: [Qemu-devel] [BUG] need to export variables in config.mak

[Richard Henderson]

On 09/30/2011 10:07 AM, Chris Friesen wrote:
> We've been playing a bit with kvm-kmod-3.0b.  We use a cross compile
> environment, and one of my coworkers noticed that the variables in
> config.mak weren't actually exported and so didn't actually have any
> effect.

Please elaborate on "no effect", and what actual problems you are
experiencing.  I do cross-compilation builds all the time and have
no such problems.


r~

Re: [Qemu-devel] [BUG] need to export variables in config.mak

[Alexander Graf]

Am 30.09.2011 um 19:52 schrieb Richard Henderson <rth@twiddle.net>:

> On 09/30/2011 10:07 AM, Chris Friesen wrote:
>> We've been playing a bit with kvm-kmod-3.0b.  We use a cross compile
>> environment, and one of my coworkers noticed that the variables in
>> config.mak weren't actually exported and so didn't actually have any
>> effect.
> 
> Please elaborate on "no effect", and what actual problems you are
> experiencing.  I do cross-compilation builds all the time and have
> no such problems.

You cross-compile kvm-kmod?

Alex
> 

Re: [Qemu-devel] [BUG] need to export variables in config.mak

[Chris Friesen]

On 09/30/2011 11:52 AM, Richard Henderson wrote:
> On 09/30/2011 10:07 AM, Chris Friesen wrote:
>> We've been playing a bit with kvm-kmod-3.0b.  We use a cross compile
>> environment, and one of my coworkers noticed that the variables in
>> config.mak weren't actually exported and so didn't actually have any
>> effect.
>
> Please elaborate on "no effect", and what actual problems you are
> experiencing.  I do cross-compilation builds all the time and have
> no such problems.

The behaviour I see is that I configure with --cross-prefix=<prefix> 
then the appropriate prefix gets set in config.mak.  However, when 
running "make" the prefix doesn't actually get used.

If building for the same target as the host machine this isn't 
immediately obvious because it uses the host compiler.  However, if you 
run "make V=1" it will show which compiler is being used.

Chris

-- 
Chris Friesen
Software Developer
GENBAND
chris.friesen@genband.com
www.genband.com