From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RAL83-0001jY-N3 for qemu-devel@nongnu.org; Sun, 02 Oct 2011 08:26:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RAL82-0005vC-My for qemu-devel@nongnu.org; Sun, 02 Oct 2011 08:26:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RAL82-0005v4-Ek for qemu-devel@nongnu.org; Sun, 02 Oct 2011 08:26:46 -0400 Message-ID: <4E885873.60708@redhat.com> Date: Sun, 02 Oct 2011 14:26:27 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1315197304-22469-1-git-send-email-david@gibson.dropbear.id.au> <1315197304-22469-2-git-send-email-david@gibson.dropbear.id.au> <20111002102547.GC30747@redhat.com> <4E883CF4.6060606@redhat.com> <20111002105238.GE30747@redhat.com> <4E8843DB.1020404@redhat.com> <20111002111700.GF30747@redhat.com> <4E885286.30905@redhat.com> <20111002121426.GK30747@redhat.com> In-Reply-To: <20111002121426.GK30747@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, joerg.roedel@amd.com, qemu-devel@nongnu.org, agraf@suse.de, kraxel@redhat.com, eduard.munteanu@linux360.ro, David Gibson , rth@twiddle.net On 10/02/2011 02:14 PM, Michael S. Tsirkin wrote: > > > > These are fine - explicit endianness. > > Right. So changing these to e.g. stl_dma and assuming > LE is default seems like a step backwards. Agree. "l" implies a word with some endianness, not "4 unstructured bytes". -- error compiling committee.c: too many arguments to function