From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RAP5G-0004QL-Ht for qemu-devel@nongnu.org; Sun, 02 Oct 2011 12:40:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RAP5E-0004k7-NV for qemu-devel@nongnu.org; Sun, 02 Oct 2011 12:40:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RAP5E-0004k0-FH for qemu-devel@nongnu.org; Sun, 02 Oct 2011 12:40:08 -0400 Message-ID: <4E8893DF.4040501@redhat.com> Date: Sun, 02 Oct 2011 18:39:59 +0200 From: Avi Kivity MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Jan Kiszka , Anthony Liguori , qemu-devel On 09/28/2011 09:01 PM, Blue Swirl wrote: > On Wed, Sep 28, 2011 at 11:00 AM, Jan Kiszka wrote: > > As we clearly modify the PIC state on pic_reset, we also have to update > > the IRQ output. This only happened on init so far. Apply this > > consistently. > > Nack, IRQ lines shouldn't be touched on reset. The other side may not > be ready for receiving the interrupt change and qemu_irqs are > stateless anyway. > The way to fix it is two-phase reset: phase 1: reset internal state (-> move all outputs to reset values), don't sample inputs yet phase 2: allow sampling inputs -- error compiling committee.c: too many arguments to function