From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54568)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1RAQ7s-0004CB-Qp
	for qemu-devel@nongnu.org; Sun, 02 Oct 2011 13:46:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1RAQ7r-00088T-Bg
	for qemu-devel@nongnu.org; Sun, 02 Oct 2011 13:46:56 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:48649)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1RAQ7r-00087u-0h
	for qemu-devel@nongnu.org; Sun, 02 Oct 2011 13:46:55 -0400
Message-ID: <4E88A388.9020105@web.de>
Date: Sun, 02 Oct 2011 19:46:48 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <cover.1317207666.git.jan.kiszka@siemens.com>
	<bcaf89ca8b39b60707d5d3b3f4fa4d2dbd56ffb6.1317207666.git.jan.kiszka@siemens.com>
	<CAAu8pHv+UfBP7d4q=CnhisSoNRscKLFqfxBQm84fi18Rxkdi+Q@mail.gmail.com>
	<4E8893DF.4040501@redhat.com>
In-Reply-To: <4E8893DF.4040501@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigD4ACF2D345B2A1339501464F"
Sender: jan.kiszka@web.de
Subject: Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigD4ACF2D345B2A1339501464F
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 2011-10-02 18:39, Avi Kivity wrote:
> On 09/28/2011 09:01 PM, Blue Swirl wrote:
>> On Wed, Sep 28, 2011 at 11:00 AM, Jan Kiszka<jan.kiszka@siemens.com>=20
>> wrote:
>> >  As we clearly modify the PIC state on pic_reset, we also have to
>> update
>> >  the IRQ output. This only happened on init so far. Apply this
>> >  consistently.
>>
>> Nack, IRQ lines shouldn't be touched on reset. The other side may not
>> be ready for receiving the interrupt change and qemu_irqs are
>> stateless anyway.
>>
>=20
> The way to fix it is two-phase reset:
>=20
> phase 1: reset internal state (-> move all outputs to reset values),
> don't sample inputs yet
> phase 2: allow sampling inputs

As far as I understood Anthony's QOM plans, phase 1 will correspond to
"unrealize", phase 2 to "realize".

However, we do not depend on two phases in this particular case (i8259)
and can live with a coalescing both for now.

Jan


--------------enigD4ACF2D345B2A1339501464F
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6Io4wACgkQitSsb3rl5xRCcgCdFy/BsaYEuPUidWolKzQ9OM0G
VqUAnjftzFCSAh2KOtxXSO/Fget+sg+G
=vedn
-----END PGP SIGNATURE-----

--------------enigD4ACF2D345B2A1339501464F--