qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Chris Friesen <chris.friesen@genband.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] need to export variables in config.mak
Date: Mon, 03 Oct 2011 09:57:52 +0200	[thread overview]
Message-ID: <4E896B00.3010201@web.de> (raw)
In-Reply-To: <4E85FF04.40806@genband.com>

[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]

On 2011-09-30 19:40, Chris Friesen wrote:
> The variables being written to config.mak by configure
> need to be exported in order to take effect when building
> the package.
> 
> The following patch fixes this in our environment.
> 
> Signed-off-by: Chris Friesen <chris.friesen@genband.com>
> 
> 
> Index: kvm-kmod-3.0b/configure
> ===================================================================
> --- kvm-kmod-3.0b.orig/configure	2011-09-27 15:12:08.000009000 -0500
> +++ kvm-kmod-3.0b/configure	2011-09-27 15:11:59.001566000 -0500
> @@ -168,24 +168,24 @@ fi
>  rm -f include/asm include-compat/asm
>  mkdir -p include
>  ln -sf asm-"$karch" include/asm
>  ln -sf asm-"$karch" include-compat/asm
>  
>  cat <<EOF > config.mak
> -ARCH=$arch
> -PROCESSOR=$processor
> -PREFIX=$prefix
> -KERNELDIR=$kerneldir
> -KERNELSOURCEDIR=$kernelsourcedir
> -KERNELVERSION=$kernel_version_str
> -CROSS_COMPILE=$cross_prefix
> -CC=$cross_prefix$cc
> -LD=$cross_prefix$ld
> -OBJCOPY=$cross_prefix$objcopy
> -AR=$cross_prefix$ar
> -KVM_VERSION=$(kvm_version)
> +export ARCH=$arch
> +export PROCESSOR=$processor
> +export PREFIX=$prefix
> +export KERNELDIR=$kerneldir
> +export KERNELSOURCEDIR=$kernelsourcedir
> +export KERNELVERSION=$kernel_version_str
> +export CROSS_COMPILE=$cross_prefix
> +export CC=$cross_prefix$cc
> +export LD=$cross_prefix$ld
> +export OBJCOPY=$cross_prefix$objcopy
> +export AR=$cross_prefix$ar
> +export KVM_VERSION=$(kvm_version)
>  EOF
>  
>  cat <<EOF > kvm-kmod-config.h
>  #define KERNEL_EXTRAVERSION $kernel_extraversion
>  $config_fedora_kernel
>  EOF
> 

Thanks, merged. I just dropped the export from those variables that are
kvm-kmod-only.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  reply	other threads:[~2011-10-03  7:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-30 17:07 [Qemu-devel] [BUG] need to export variables in config.mak Chris Friesen
2011-09-30 17:12 ` Jan Kiszka
2011-09-30 17:40   ` [Qemu-devel] [PATCH] " Chris Friesen
2011-10-03  7:57     ` Jan Kiszka [this message]
2011-09-30 17:52 ` [Qemu-devel] [BUG] " Richard Henderson
2011-09-30 18:00   ` Alexander Graf
2011-09-30 18:14   ` Chris Friesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E896B00.3010201@web.de \
    --to=jan.kiszka@web.de \
    --cc=avi@redhat.com \
    --cc=chris.friesen@genband.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).