From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RAdPU-0000LQ-6E for qemu-devel@nongnu.org; Mon, 03 Oct 2011 03:58:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RAdPS-0005VA-Vm for qemu-devel@nongnu.org; Mon, 03 Oct 2011 03:58:00 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:40790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RAdPS-0005Ur-K1 for qemu-devel@nongnu.org; Mon, 03 Oct 2011 03:57:58 -0400 Message-ID: <4E896B00.3010201@web.de> Date: Mon, 03 Oct 2011 09:57:52 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E85F741.2050100@genband.com> <4E85F86A.7070305@siemens.com> <4E85FF04.40806@genband.com> In-Reply-To: <4E85FF04.40806@genband.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigED968F3D0A885955119B40DE" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH] need to export variables in config.mak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Friesen Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigED968F3D0A885955119B40DE Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-09-30 19:40, Chris Friesen wrote: > The variables being written to config.mak by configure > need to be exported in order to take effect when building > the package. >=20 > The following patch fixes this in our environment. >=20 > Signed-off-by: Chris Friesen >=20 >=20 > Index: kvm-kmod-3.0b/configure > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- kvm-kmod-3.0b.orig/configure 2011-09-27 15:12:08.000009000 -0500 > +++ kvm-kmod-3.0b/configure 2011-09-27 15:11:59.001566000 -0500 > @@ -168,24 +168,24 @@ fi > rm -f include/asm include-compat/asm > mkdir -p include > ln -sf asm-"$karch" include/asm > ln -sf asm-"$karch" include-compat/asm > =20 > cat < config.mak > -ARCH=3D$arch > -PROCESSOR=3D$processor > -PREFIX=3D$prefix > -KERNELDIR=3D$kerneldir > -KERNELSOURCEDIR=3D$kernelsourcedir > -KERNELVERSION=3D$kernel_version_str > -CROSS_COMPILE=3D$cross_prefix > -CC=3D$cross_prefix$cc > -LD=3D$cross_prefix$ld > -OBJCOPY=3D$cross_prefix$objcopy > -AR=3D$cross_prefix$ar > -KVM_VERSION=3D$(kvm_version) > +export ARCH=3D$arch > +export PROCESSOR=3D$processor > +export PREFIX=3D$prefix > +export KERNELDIR=3D$kerneldir > +export KERNELSOURCEDIR=3D$kernelsourcedir > +export KERNELVERSION=3D$kernel_version_str > +export CROSS_COMPILE=3D$cross_prefix > +export CC=3D$cross_prefix$cc > +export LD=3D$cross_prefix$ld > +export OBJCOPY=3D$cross_prefix$objcopy > +export AR=3D$cross_prefix$ar > +export KVM_VERSION=3D$(kvm_version) > EOF > =20 > cat < kvm-kmod-config.h > #define KERNEL_EXTRAVERSION $kernel_extraversion > $config_fedora_kernel > EOF >=20 Thanks, merged. I just dropped the export from those variables that are kvm-kmod-only. Jan --------------enigED968F3D0A885955119B40DE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6JawMACgkQitSsb3rl5xR5EgCg73lpjMug9FMzPUg1ZVibke4E pqYAoLuaJtLiwmLNpPwVKRpXBMOPOC7C =NOwT -----END PGP SIGNATURE----- --------------enigED968F3D0A885955119B40DE--