From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RApVl-0000cG-BW for qemu-devel@nongnu.org; Mon, 03 Oct 2011 16:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RApVk-00033K-H2 for qemu-devel@nongnu.org; Mon, 03 Oct 2011 16:53:17 -0400 Message-ID: <4E8A208E.3050201@freescale.com> Date: Mon, 3 Oct 2011 15:52:30 -0500 From: Scott Wood MIME-Version: 1.0 References: <1317674600-19083-1-git-send-email-sw@weilnetz.de> <1317674600-19083-3-git-send-email-sw@weilnetz.de> In-Reply-To: <1317674600-19083-3-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-ppc@nongnu.org, QEMU Developers On 10/03/2011 03:43 PM, Stefan Weil wrote: > qemu_cache_utils_init() is only used by ppc / ppc64 tcg targets > to initialize the cache before flush_icache_range() is called. > > This patch moves the code to tcg/ppc and tcg/ppc64. > Initialisation is called from tcg_target_init() there. > > Signed-off-by: Stefan Weil This is not only needed for TCG. We need flush_icache_range() for KVM. See http://patchwork.ozlabs.org/patch/90403/ and the thread starting with http://lists.gnu.org/archive/html/qemu-ppc/2011-09/msg00180.html And must this be duplicated between ppc and ppc64? -Scott