* [Qemu-devel] [PATCH] s390: fix short kernel command lines
@ 2011-09-23 13:38 Christian Borntraeger
2011-10-04 12:08 ` Alexander Graf
0 siblings, 1 reply; 2+ messages in thread
From: Christian Borntraeger @ 2011-09-23 13:38 UTC (permalink / raw)
To: Alexander Graf; +Cc: Carsten Otte, qemu-devel@nongnu.org
The default kernel command line for s390 is
"root=/dev/ram0 ro"
When overriding this line, we have to ensure to also copy the \0 to
avoid false lines, for example, -append "root=/dev/vda" will result in
"root=/dev/vda0 ro" with the current code.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
hw/s390-virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/hw/s390-virtio.c
===================================================================
--- a/hw/s390-virtio.c
+++ b/hw/s390-virtio.c
@@ -238,7 +238,7 @@ static void s390_init(ram_addr_t my_ram_
if (kernel_cmdline) {
cpu_physical_memory_write(KERN_PARM_AREA, kernel_cmdline,
- strlen(kernel_cmdline));
+ strlen(kernel_cmdline) + 1);
}
/* Create VirtIO network adapters */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] s390: fix short kernel command lines
2011-09-23 13:38 [Qemu-devel] [PATCH] s390: fix short kernel command lines Christian Borntraeger
@ 2011-10-04 12:08 ` Alexander Graf
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Graf @ 2011-10-04 12:08 UTC (permalink / raw)
To: Christian Borntraeger; +Cc: Carsten Otte, qemu-devel@nongnu.org
On 09/23/2011 03:38 PM, Christian Borntraeger wrote:
> The default kernel command line for s390 is
> "root=/dev/ram0 ro"
>
> When overriding this line, we have to ensure to also copy the \0 to
> avoid false lines, for example, -append "root=/dev/vda" will result in
> "root=/dev/vda0 ro" with the current code.
>
> Signed-off-by: Christian Borntraeger<borntraeger@de.ibm.com>
Thanks, applied to s390-next.
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-04 12:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-23 13:38 [Qemu-devel] [PATCH] s390: fix short kernel command lines Christian Borntraeger
2011-10-04 12:08 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).