From: Alexander Graf <agraf@suse.de>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Stefan Weil <weil@mail.berlios.de>,
Carsten Otte <cotte@de.ibm.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Blue Swirl <blauwirbel@gmail.com>,
rth@twiddle.net
Subject: Re: [Qemu-devel] build errors on s390 tcg
Date: Tue, 04 Oct 2011 14:23:05 +0200 [thread overview]
Message-ID: <4E8AFAA9.3060705@suse.de> (raw)
In-Reply-To: <4E8AF3EB.1010103@de.ibm.com>
On 10/04/2011 01:54 PM, Christian Borntraeger wrote:
> With todays qemu git I get the following error when compiling for s390:
>
> In file included from /home/cborntra/REPOS/qemu/tcg/tcg.c:175:0:
> /home/cborntra/REPOS/qemu/tcg/s390/tcg-target.c:677:13: error: conflicting types for ‘tcg_out_mov’
> /home/cborntra/REPOS/qemu/tcg/tcg.c:76:13: note: previous declaration of ‘tcg_out_mov’ was here
> /home/cborntra/REPOS/qemu/tcg/s390/tcg-target.c:689:13: error: conflicting types for ‘tcg_out_movi’
> /home/cborntra/REPOS/qemu/tcg/tcg.c:77:13: note: previous declaration of ‘tcg_out_movi’ was here
> /home/cborntra/REPOS/qemu/tcg/s390/tcg-target.c:829:20: error: conflicting types for ‘tcg_out_ld’
> /home/cborntra/REPOS/qemu/tcg/tcg.c:74:13: note: previous declaration of ‘tcg_out_ld’ was here
> /home/cborntra/REPOS/qemu/tcg/s390/tcg-target.c:839:20: error: conflicting types for ‘tcg_out_st’
> /home/cborntra/REPOS/qemu/tcg/tcg.c:81:13: note: previous declaration of ‘tcg_out_st’ was here
> make[1]: *** [tcg/tcg.o] Error 1
>
> reverting c0ad3001bf12292b137b05e1c4643f31c6b0a727 ""tcg: Add forward declarations for local functions"
> solves the problem, but it just hides the problem. Any ideas howto solve that properly?
The problem is that tcg.c defines the functions with int arguments for
TCG register indexes, while s390/tcg-target.c takes TCGReg parameters.
I'm not sure which way is better, but using TCGReg feels more type safe
to me.
Alex
next prev parent reply other threads:[~2011-10-04 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 11:54 [Qemu-devel] build errors on s390 tcg Christian Borntraeger
2011-10-04 12:23 ` Alexander Graf [this message]
2011-10-04 12:44 ` Peter Maydell
2011-10-04 16:41 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8AFAA9.3060705@suse.de \
--to=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).