From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47939)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1RB41d-0003Yn-Ke
	for qemu-devel@nongnu.org; Tue, 04 Oct 2011 08:23:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1RB41Y-0003Pe-R0
	for qemu-devel@nongnu.org; Tue, 04 Oct 2011 08:23:09 -0400
Received: from cantor2.suse.de ([195.135.220.15]:54706 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1RB41Y-0003PZ-JZ
	for qemu-devel@nongnu.org; Tue, 04 Oct 2011 08:23:04 -0400
Message-ID: <4E8AFAA9.3060705@suse.de>
Date: Tue, 04 Oct 2011 14:23:05 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <4E8AF3EB.1010103@de.ibm.com>
In-Reply-To: <4E8AF3EB.1010103@de.ibm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] build errors on s390 tcg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Stefan Weil <weil@mail.berlios.de>, Carsten Otte <cotte@de.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, rth@twiddle.net

On 10/04/2011 01:54 PM, Christian Borntraeger wrote:
> With todays qemu git I get the following error when compiling for s390:
>
> In file included from /home/cborntra/REPOS/qemu/tcg/tcg.c:175:0:
> /home/cborntra/REPOS/qemu/tcg/s390/tcg-target.c:677:13: error: conflict=
ing types for =91tcg_out_mov=92
> /home/cborntra/REPOS/qemu/tcg/tcg.c:76:13: note: previous declaration o=
f =91tcg_out_mov=92 was here
> /home/cborntra/REPOS/qemu/tcg/s390/tcg-target.c:689:13: error: conflict=
ing types for =91tcg_out_movi=92
> /home/cborntra/REPOS/qemu/tcg/tcg.c:77:13: note: previous declaration o=
f =91tcg_out_movi=92 was here
> /home/cborntra/REPOS/qemu/tcg/s390/tcg-target.c:829:20: error: conflict=
ing types for =91tcg_out_ld=92
> /home/cborntra/REPOS/qemu/tcg/tcg.c:74:13: note: previous declaration o=
f =91tcg_out_ld=92 was here
> /home/cborntra/REPOS/qemu/tcg/s390/tcg-target.c:839:20: error: conflict=
ing types for =91tcg_out_st=92
> /home/cborntra/REPOS/qemu/tcg/tcg.c:81:13: note: previous declaration o=
f =91tcg_out_st=92 was here
> make[1]: *** [tcg/tcg.o] Error 1
>
> reverting c0ad3001bf12292b137b05e1c4643f31c6b0a727 ""tcg: Add forward d=
eclarations for local functions"
> solves the problem, but it just hides the problem. Any ideas howto solv=
e that properly?

The problem is that tcg.c defines the functions with int arguments for=20
TCG register indexes, while s390/tcg-target.c takes TCGReg parameters.=20
I'm not sure which way is better, but using TCGReg feels more type safe=20
to me.


Alex