From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42018)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RB6PP-000461-Mz
	for qemu-devel@nongnu.org; Tue, 04 Oct 2011 10:55:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RB6PL-0004eM-JI
	for qemu-devel@nongnu.org; Tue, 04 Oct 2011 10:55:51 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:51979)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RB6PL-0004eF-FU
	for qemu-devel@nongnu.org; Tue, 04 Oct 2011 10:55:47 -0400
Received: by ywm39 with SMTP id 39so686846ywm.4
	for <qemu-devel@nongnu.org>; Tue, 04 Oct 2011 07:55:46 -0700 (PDT)
Message-ID: <4E8B1E6F.8060506@codemonkey.ws>
Date: Tue, 04 Oct 2011 09:55:43 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1316782367.git.quintela@redhat.com>	<1ecde435c002123860f03fa720f20ff9225fab1b.1316782367.git.quintela@redhat.com>	<4E8B16F8.1050808@codemonkey.ws>
	<m3mxdgddef.fsf@trasno.mitica>
In-Reply-To: <m3mxdgddef.fsf@trasno.mitica>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 05/23] migration: Refactor MigrationState
 creation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org

On 10/04/2011 09:44 AM, Juan Quintela wrote:
> Anthony Liguori<anthony@codemonkey.ws>  wrote:
>> On 09/23/2011 07:56 AM, Juan Quintela wrote:
>>> Signed-off-by: Juan Quintela<quintela@redhat.com>
>>
>>
>> I think this would fit better if it were migrate_new() or migrate_open().
>>
>> It definitely should be in the form noun_verb and not noun_verb_noun().
>>
>> Regards,
>
> You are the native speaker, so I change this one O:-)

It's just consistency, not about what sounds good.

bdrv_new(), bdrv_open(), qemu_chr_open(), memory_region_init(), etc.

Regards,

Anthony Liguori

>
> Later, Juan.
>