From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RB9bM-0002kO-5e for qemu-devel@nongnu.org; Tue, 04 Oct 2011 14:20:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RB9bG-000714-GP for qemu-devel@nongnu.org; Tue, 04 Oct 2011 14:20:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RB9bG-000710-7z for qemu-devel@nongnu.org; Tue, 04 Oct 2011 14:20:18 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p94IKHNe008521 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Oct 2011 14:20:17 -0400 Message-ID: <4E8B4E59.9030607@redhat.com> Date: Tue, 04 Oct 2011 20:20:09 +0200 From: Avi Kivity MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On 10/04/2011 04:38 PM, Juan Quintela wrote: > Hi > > This series move the subsections detection code form: > - Look that it starts form 5 > To: > - Look that it starts form 5 (SUBSECTION) > - Look at the length > - Look that length is bigger than section name > - Look at the idstr and see that it starts with the subsection name. > > Please review. > The original intent with subsections was to register them as a new vmstate section, with just a name relationship. Can we rename .subsections to .old_and_semi_broken_subsections, and introduce a new .subsections field that works properly in all cases? -- error compiling committee.c: too many arguments to function