From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RB9ru-0003mi-4r for qemu-devel@nongnu.org; Tue, 04 Oct 2011 14:37:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RB9rs-0001aO-9U for qemu-devel@nongnu.org; Tue, 04 Oct 2011 14:37:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RB9rr-0001Zw-Sg for qemu-devel@nongnu.org; Tue, 04 Oct 2011 14:37:28 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p94IbRZ6031469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Oct 2011 14:37:27 -0400 Message-ID: <4E8B5264.5030305@redhat.com> Date: Tue, 04 Oct 2011 20:37:24 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4E8B4E59.9030607@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On 10/04/2011 08:35 PM, Juan Quintela wrote: > Avi Kivity wrote: > > On 10/04/2011 04:38 PM, Juan Quintela wrote: > >> Hi > >> > >> This series move the subsections detection code form: > >> - Look that it starts form 5 > >> To: > >> - Look that it starts form 5 (SUBSECTION) > >> - Look at the length > >> - Look that length is bigger than section name > >> - Look at the idstr and see that it starts with the subsection name. > >> > >> Please review. > >> > > > > The original intent with subsections was to register them as a new > > vmstate section, with just a name relationship. > > > > Can we rename .subsections to .old_and_semi_broken_subsections, and > > introduce a new .subsections field that works properly in all cases? > > Not easily. We can try to do something, but the problem is that > subsection are just that "sub", and we should have to be very careful > with post-load handlers. > If necessary the subsection's post-load handler can re-run the main post-load handler (or it can even be the same post-load handler, unconditionally). We just have to make sure that post-load handlers are idempotent. -- error compiling committee.c: too many arguments to function