qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Juan Quintela <quintela@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] savevm: teach qemu_fill_buffer to do partial refills
Date: Wed, 05 Oct 2011 14:41:20 -0500	[thread overview]
Message-ID: <4E8CB2E0.2000701@codemonkey.ws> (raw)
In-Reply-To: <b7364a48b984bf28cd7f64c01d60ddcbbc76a189.1317738629.git.quintela@redhat.com>

On 10/04/2011 09:38 AM, Juan Quintela wrote:
> We will need on next patch to be able to lookahead on next patch
>
> Signed-off-by: Juan Quintela<quintela@redhat.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>   savevm.c |   14 +++++++++++---
>   1 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index 46f2447..31131df 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -455,6 +455,7 @@ void qemu_fflush(QEMUFile *f)
>   static void qemu_fill_buffer(QEMUFile *f)
>   {
>       int len;
> +    int used;
>
>       if (!f->get_buffer)
>           return;
> @@ -462,10 +463,17 @@ static void qemu_fill_buffer(QEMUFile *f)
>       if (f->is_write)
>           abort();
>
> -    len = f->get_buffer(f->opaque, f->buf, f->buf_offset, IO_BUF_SIZE);
> +    used = f->buf_size - f->buf_index;
> +    if (used>  0) {
> +        memmove(f->buf, f->buf + f->buf_index, used);
> +    }
> +    f->buf_index = 0;
> +    f->buf_size = used;
> +
> +    len = f->get_buffer(f->opaque, f->buf + used, f->buf_offset,
> +                        IO_BUF_SIZE - used);
>       if (len>  0) {
> -        f->buf_index = 0;
> -        f->buf_size = len;
> +        f->buf_size += len;
>           f->buf_offset += len;
>       } else if (len != -EAGAIN)
>           f->has_error = 1;

  reply	other threads:[~2011-10-05 19:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04 14:38 [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection Juan Quintela
2011-10-04 14:38 ` [Qemu-devel] [PATCH 1/4] savevm: teach qemu_fill_buffer to do partial refills Juan Quintela
2011-10-05 19:41   ` Anthony Liguori [this message]
2011-10-04 14:38 ` [Qemu-devel] [PATCH 2/4] savevm: some coding style cleanups Juan Quintela
2011-10-05 19:41   ` Anthony Liguori
2011-10-04 14:38 ` [Qemu-devel] [PATCH 3/4] savevm: improve subsections detection on load Juan Quintela
2011-10-05 19:45   ` Anthony Liguori
2011-10-06  8:38     ` Paolo Bonzini
2011-10-04 14:38 ` [Qemu-devel] [PATCH 4/4] Revert "savevm: fix corruption in vmstate_subsection_load()." Juan Quintela
2011-10-05 19:46   ` Anthony Liguori
2011-10-04 15:12 ` [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection Paolo Bonzini
2011-10-04 18:20 ` Avi Kivity
2011-10-04 18:22   ` Anthony Liguori
2011-10-04 18:28     ` Avi Kivity
2011-10-04 18:35   ` Juan Quintela
2011-10-04 18:37     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8CB2E0.2000701@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).