From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47545)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RBXWC-0000SW-5E
	for qemu-devel@nongnu.org; Wed, 05 Oct 2011 15:52:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RBXW9-0000PL-T2
	for qemu-devel@nongnu.org; Wed, 05 Oct 2011 15:52:40 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:35091)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RBXW9-0000P2-QP
	for qemu-devel@nongnu.org; Wed, 05 Oct 2011 15:52:37 -0400
Received: by ywm39 with SMTP id 39so2327436ywm.4
	for <qemu-devel@nongnu.org>; Wed, 05 Oct 2011 12:52:37 -0700 (PDT)
Message-ID: <4E8CB581.4030900@codemonkey.ws>
Date: Wed, 05 Oct 2011 14:52:33 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1316781876.git.quintela@redhat.com>	<5529f9bd516a73e64eb7f9761e85cd2240030dfd.1316781876.git.quintela@redhat.com>	<4E8B4B82.4080107@codemonkey.ws>
	<m3fwj8bo4z.fsf@trasno.mitica>
In-Reply-To: <m3fwj8bo4z.fsf@trasno.mitica>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/11] migration: return real error code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org

On 10/04/2011 01:35 PM, Juan Quintela wrote:
> Anthony Liguori<anthony@codemonkey.ws>  wrote:
>> On 09/23/2011 07:50 AM, Juan Quintela wrote:
>>> make functions propaget errno, instead of just using -EIO.
>>>
>>> Signed-off-by: Juan Quintela<quintela@redhat.com>
>>
>> qemu_file_has_error() implies a boolean response.  Wouldn't
>> qemu_file_get_error() make more sense if you're going to rely on the
>> return value?
>
> I just didn't want to change more things on the same patch.
> I can add a patch on top of this series?

It's terribly odd to make a function that looks like a bool return a non-boolean 
value.  It can't be that much of a change to do it in this patch, it's just a 
matter of running sed.

Regards,

Anthony Liguori

>
> Later, Juan.