From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57264)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RBjTv-0007bA-8g
	for qemu-devel@nongnu.org; Thu, 06 Oct 2011 04:39:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RBjTp-0000Z4-NV
	for qemu-devel@nongnu.org; Thu, 06 Oct 2011 04:39:07 -0400
Received: from mail-bw0-f45.google.com ([209.85.214.45]:56582)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RBjTp-0000Yx-D4
	for qemu-devel@nongnu.org; Thu, 06 Oct 2011 04:39:01 -0400
Received: by bkbzv15 with SMTP id zv15so3132730bkb.4
	for <qemu-devel@nongnu.org>; Thu, 06 Oct 2011 01:38:59 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E8D6920.1020003@redhat.com>
Date: Thu, 06 Oct 2011 10:38:56 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1317738629.git.quintela@redhat.com>
	<e102d670b1d5eba2256bc125ba0ec4a34f0983b0.1317738629.git.quintela@redhat.com>
	<4E8CB3DB.7020204@codemonkey.ws>
In-Reply-To: <4E8CB3DB.7020204@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] savevm: improve subsections detection
	on load
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

On 10/05/2011 09:45 PM, Anthony Liguori wrote:
>>
>>   int qemu_get_buffer(QEMUFile *f, uint8_t *buf, int size1)
>>   {
>>       int size, l;
>
> Can we implement get_buffer in terms of peek_buffer and just increment
> f->buf_index in get_buffer?

No, get_buffer works even if size1 is greater than the size of the 
buffer, peek_buffer doesn't.

Paolo