From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46272)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RBqmB-0002U3-Vq
	for qemu-devel@nongnu.org; Thu, 06 Oct 2011 12:26:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RBqmB-0006T9-2U
	for qemu-devel@nongnu.org; Thu, 06 Oct 2011 12:26:27 -0400
Received: from mail-bw0-f45.google.com ([209.85.214.45]:65002)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RBqmA-0006Sw-RD
	for qemu-devel@nongnu.org; Thu, 06 Oct 2011 12:26:27 -0400
Received: by bkbzv15 with SMTP id zv15so3659945bkb.4
	for <qemu-devel@nongnu.org>; Thu, 06 Oct 2011 09:26:26 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E8DD6A7.7050404@redhat.com>
Date: Thu, 06 Oct 2011 18:26:15 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1317911543.git.quintela@redhat.com>
	<49696d43bab6d485d414cfe58772c9ac54926b63.1317911543.git.quintela@redhat.com>
In-Reply-To: <49696d43bab6d485d414cfe58772c9ac54926b63.1317911543.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using
	qemu_peek_byte()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On 10/06/2011 06:21 PM, Juan Quintela wrote:
> +    result = qemu_peek_byte(f);
> +
> +    if (f->buf_index<  f->buf_size) {
> +        f->buf_index++;
>       }

This should really be an assert that f->buf_index < f->buf_size, 
otherwise qemu_peek_byte has read garbage.

Paolo