* [Qemu-devel] [RFC] Use TCGReg for all TCG targets?
@ 2011-10-06 16:24 Stefan Weil
2011-10-06 17:08 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2011-10-06 16:24 UTC (permalink / raw)
To: QEMU Developers, Richard Henderson, Alexander Graf
Cc: Blue Swirl, Aurelien Jarno
Hi,
commit 48bb3750e13cbb5a634d3aeab5191d74d124232f
introduced the data type 'TCGReg' in tcg/s390.
Today, s390 is the only TCG target which uses TCGReg.
This causes a conflict with my commit
c0ad3001bf12292b137b05e1c4643f31c6b0a727,
because some function prototypes in tcg/s390/tcg-target.c
differ from those in all the other TCG targets.
Builds on s390 hosts are broken now.
I'd like to use TCGReg in all TCG targets, thus fixing the
conflict and improving readability of the code
('TCGReg' is more specific than 'int').
Is there consensus that this is a good idea, or should
TCGReg be removed (then all TCG targets use int) or only
used for s390?
I cc'ed all TCG maintainers because their code would
have to be changed.
Regards,
Stefan Weil
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [RFC] Use TCGReg for all TCG targets?
2011-10-06 16:24 [Qemu-devel] [RFC] Use TCGReg for all TCG targets? Stefan Weil
@ 2011-10-06 17:08 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2011-10-06 17:08 UTC (permalink / raw)
To: Stefan Weil; +Cc: QEMU Developers, Alexander Graf, Blue Swirl, Aurelien Jarno
On 10/06/2011 09:24 AM, Stefan Weil wrote:
> Is there consensus that this is a good idea, or should
> TCGReg be removed (then all TCG targets use int) or only
> used for s390?
I think it's a good idea.
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-06 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-06 16:24 [Qemu-devel] [RFC] Use TCGReg for all TCG targets? Stefan Weil
2011-10-06 17:08 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).