From: Alexander Graf <agraf@suse.de>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Set an invalid-bits mask for each SPE instructions
Date: Fri, 07 Oct 2011 14:40:47 +0200 [thread overview]
Message-ID: <4E8EF34F.3010309@suse.de> (raw)
In-Reply-To: <1317225245-24360-1-git-send-email-chouteau@adacore.com>
On 09/28/2011 05:54 PM, Fabien Chouteau wrote:
> SPE instructions are defined by pairs. Currently, the invalid-bits mask is set
> for the first instruction, but the second one can have a different mask.
>
> example:
> GEN_SPE(efdcmpeq, efdcfs, 0x17, 0x0B, 0x00600000, 0x00180000, PPC_SPE_DOUBLE),
>
> Signed-off-by: Fabien Chouteau<chouteau@adacore.com>
It certainly doesn't make the code more ugly than it was before :).
Applied to my local ppc-next branch. I take it that you verified all the
invalid masks are sane.
There are some lines exceeding 80 characters, but I'm fairly sure they
did before too. So I'll let this slip through for the sake of readability.
Alex
next prev parent reply other threads:[~2011-10-07 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 15:54 [Qemu-devel] [PATCH] Set an invalid-bits mask for each SPE instructions Fabien Chouteau
2011-10-06 14:41 ` Fabien Chouteau
2011-10-07 12:40 ` Alexander Graf [this message]
2011-10-07 13:10 ` Fabien Chouteau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8EF34F.3010309@suse.de \
--to=agraf@suse.de \
--cc=chouteau@adacore.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).