From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RCXAD-0000VB-Fd for qemu-devel@nongnu.org; Sat, 08 Oct 2011 09:42:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RCXAC-0006tK-DM for qemu-devel@nongnu.org; Sat, 08 Oct 2011 09:42:05 -0400 Received: from mail-ey0-f173.google.com ([209.85.215.173]:51315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RCXAC-0006tF-8D for qemu-devel@nongnu.org; Sat, 08 Oct 2011 09:42:04 -0400 Received: by eye4 with SMTP id 4so2169966eye.4 for ; Sat, 08 Oct 2011 06:42:03 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4E905326.1070908@redhat.com> Date: Sat, 08 Oct 2011 15:41:58 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20111003163352.GA22822@davesworkthinkpad> <4E89F62E.1020804@web.de> <87lit0n66z.fsf@ginnungagap.bsc.es> <4E8B41D8.3050502@web.de> <4E8C0275.50107@redhat.com> <4E8C0CA0.2010006@web.de> <4E8C217D.10800@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gilbert Cc: peter.maydell@linaro.org, patches@linaro.org, Jan Kiszka , agraf@suse.de, qemu-devel@nongnu.org On 10/07/2011 07:29 PM, David Gilbert wrote: > Hmm this got a bit more complex than the original patch; still it covers a lot > more bases. > > Should this also replace the THREAD that's defined in > linux-user/qemu.h and bsd-user/qemu.h (that is __thread if built with > NPTL)? > It seems to only be there for 'thread_env' which is also a CPUState* > (hmm - what state does that contain that cpu_single_env doesn't?) Yes, I wouldn't be surprised if thread_env can just go. That would be a separate cleanup, however. Paolo