qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Mars.cao" <mars@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] block: zero write detection
Date: Sun, 09 Oct 2011 17:52:30 +0800	[thread overview]
Message-ID: <4E916EDE.1010601@linux.vnet.ibm.com> (raw)
In-Reply-To: <1318002589-11315-1-git-send-email-stefanha@linux.vnet.ibm.com>

On 10/07/2011 11:49 PM, Stefan Hajnoczi wrote:
> Image streaming copies data from the backing file into the image file.  It is
> important to represent zero regions from the backing file efficiently during
> streaming, otherwise the image file grows to the full virtual disk size and
> loses sparseness.
>
> There are two ways to implement zero write detection, they are subtly different:
>
> 1. Allow image formats to provide efficient representations for zero regions.
>     QED does this with "zero clusters" and it has been discussed for qcow2v3.
>
> 2. During streaming, check for zeroes and skip writing to the image file when
>     zeroes are detected.
>
> However, there are some disadvantages to #2 because it leaves unallocated holes
> in the image file.  If image streaming is aborted before it completes then it
> will be necessary to reread all unallocated clusters from the backing file upon
> resuming image streaming.  Potentionally worse is that a backing file over a
> slow remote connection will have the zero regions fetched again and again if
> the guest accesses them.  #1 avoids these problems because the image file
> contains information on which regions are zeroes and do not need to be
> refetched.
>
> This patch series implements #1 with the existing QED zero cluster feature.  In
> the future we can add qcow2v3 zero clusters too.  We can also implement #2
> directly in the image streaming code as a fallback when the BlockDriver does
> not support zero detection #1 itself.  That way we get the best possible zero
> write detection, depending on the image format.
>
> Here is a qemu-iotest to verify that zero write detection is working:
> http://repo.or.cz/w/qemu-iotests/stefanha.git/commitdiff/226949695eef51bdcdea3e6ce3d7e5a863427f37
>
> Stefan Hajnoczi (3):
>    block: add zero write detection interface
>    qed: add zero write detection support
>    qemu-io: add zero write detection option
>
>   block.c     |   16 +++++++++++
>   block.h     |    2 +
>   block/qed.c |   81 +++++++++++++++++++++++++++++++++++++++++++++++++++++------
>   block_int.h |   13 +++++++++
>   qemu-io.c   |   35 ++++++++++++++++++++-----
>   5 files changed, 132 insertions(+), 15 deletions(-)
>
I tested the patch by qemu-iotest 029 test case and also by manually, it 
worked as expected.

Tested-by: Cao,Bing Bu <mars@linux.vnet.ibm.com>

  parent reply	other threads:[~2011-10-09  9:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-07 15:49 [Qemu-devel] [PATCH 0/3] block: zero write detection Stefan Hajnoczi
2011-10-07 15:49 ` [Qemu-devel] [PATCH 1/3] block: add zero write detection interface Stefan Hajnoczi
2011-10-07 15:49 ` [Qemu-devel] [PATCH 2/3] qed: add zero write detection support Stefan Hajnoczi
2011-10-07 15:49 ` [Qemu-devel] [PATCH 3/3] qemu-io: add zero write detection option Stefan Hajnoczi
2011-10-09  9:52 ` Mars.cao [this message]
2011-10-11 13:46 ` [Qemu-devel] [PATCH 0/3] block: zero write detection Kevin Wolf
2011-10-12 10:39   ` Stefan Hajnoczi
2011-10-12 11:03     ` Kevin Wolf
2011-10-12 11:59       ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E916EDE.1010601@linux.vnet.ibm.com \
    --to=mars@linux.vnet.ibm.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).