From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54517)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1RDS36-0003qe-FV
	for qemu-devel@nongnu.org; Mon, 10 Oct 2011 22:26:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1RDS35-00009W-Bo
	for qemu-devel@nongnu.org; Mon, 10 Oct 2011 22:26:32 -0400
Received: from [222.73.24.84] (port=60341 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1RDS34-00009Q-L0
	for qemu-devel@nongnu.org; Mon, 10 Oct 2011 22:26:31 -0400
Message-ID: <4E93A987.6050608@cn.fujitsu.com>
Date: Tue, 11 Oct 2011 10:27:19 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
References: <4E8ECA91.8040409@cn.fujitsu.com> <4E8ED167.1000705@siemens.com>
	<20111008151622.GA17181@amd.home.annexia.org>
	<4E916035.5050906@web.de>
	<20111009102338.GN16799@amd.home.annexia.org>
	<4E92568E.2010507@cn.fujitsu.com> <4E929618.4040403@web.de>
	<20111010090246.GF9408@redhat.com> <4E92BC11.3030508@siemens.com>
In-Reply-To: <4E92BC11.3030508@siemens.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [Question] dump memory when host pci device is
 used by guest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, "Richard W.M. Jones" <rjones@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

At 10/10/2011 05:34 PM, Jan Kiszka Write:
> On 2011-10-10 11:02, Daniel P. Berrange wrote:

> Run gdb with "set debug remote 1" and watch the communication, it is not
> that complex. But a dump command is probably simpler for those
> scenarios, I agree.

We have determined to introduce a new command dump for such scenarios.
Now, let's to discuss the arguments for this command:

Here is the arguments for command migrate:
    {    
        .name       = "migrate",
        .args_type  = "detach:-d,blk:-b,inc:-i,uri:s",
        .params     = "[-d] [-b] [-i] uri",
...
    },   

I think the arguments -b and -i are not required for dump, and -d is useful
for dump.

We can pass the file's path or fd to qemu instead of uri.

So here is my image for command dump(reuse migration's code, not generate a standard
format core):
    {
        .name       = "dump",
        .args_type  = "detach:-d,file:s",
        .params     = "[-d] file",
...
    },

The argument can be 'file:file's path' or 'fd:fd's name'

Any advice is welcome.

Thanks
Wen Congyang
> 
> Jan
>