From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDWdg-0002NV-BI for qemu-devel@nongnu.org; Tue, 11 Oct 2011 03:20:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RDWdf-0002a4-5i for qemu-devel@nongnu.org; Tue, 11 Oct 2011 03:20:36 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:59887) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDWde-0002Zy-Jt for qemu-devel@nongnu.org; Tue, 11 Oct 2011 03:20:35 -0400 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245]) by e23smtp05.au.ibm.com (8.14.4/8.13.1) with ESMTP id p9B7DcHZ005568 for ; Tue, 11 Oct 2011 18:13:38 +1100 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p9B7KXBr2424962 for ; Tue, 11 Oct 2011 18:20:33 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p9B7KXmH014349 for ; Tue, 11 Oct 2011 18:20:33 +1100 Received: from [127.0.0.1] ([9.115.127.37]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p9B7KU9x012303 for ; Tue, 11 Oct 2011 18:20:32 +1100 Message-ID: <4E93EE0B.6070308@linux.vnet.ibm.com> Date: Tue, 11 Oct 2011 15:19:39 +0800 From: Wayne Xia MIME-Version: 1.0 References: <1317200405-5060-1-git-send-email-xiawenc@linux.vnet.ibm.com> <20111004105518.3404b76a@doriath> In-Reply-To: <20111004105518.3404b76a@doriath> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/1] Make the help info more friendly in monitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org =E4=BA=8E 2011-10-4 21:55, Luiz Capitulino =E5=86=99=E9=81=93: > On Wed, 28 Sep 2011 10:16:19 +0100 > Stefan Hajnoczi wrote: > >> On Wed, Sep 28, 2011 at 10:00 AM, Wayne Xia wrote: >>> During my test, I found it inconvenient when I type "help" or "help i= nfo", >>> because the information was shown without orderliness. This patch wou= ld just >>> show the help information in sorted order. >>> >>> For eg: >>> (qemu)help >>> acl_add >>> acl_policy >>> acl_remove >>> acl_reset >>> acl_show >>> balloon >>> block_passwd >>> ... >>> the command list is sorted. >>> >>> Wayne Xia (1): >>> Sort the help info shown in monitor >>> >>> monitor.c | 97 ++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++-- >>> 1 files changed, 93 insertions(+), 4 deletions(-) >> >> This is a nice idea. We could keep hmp/qmp-commands.hx in sorted >> order but that prevents us from keeping related commands together in >> those files (and the generated documentation?). So sorting at >> run-time makes sense. > > The info help command reads from hmp-commands.hx and the info_cmds arra= y, > I would prefer to get those sorted. > thanks, sorting info_cmds array seems more reasonable for that related things would be kept here in one place not another queue, would change in next patch. --=20 Best Regards Wayne Xia mail:xiawenc@linux.vnet.ibm.com tel:86-010-82450803