From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDX2X-0008Fr-1q for qemu-devel@nongnu.org; Tue, 11 Oct 2011 03:46:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RDX2V-0000eS-OA for qemu-devel@nongnu.org; Tue, 11 Oct 2011 03:46:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDX2V-0000e9-Aq for qemu-devel@nongnu.org; Tue, 11 Oct 2011 03:46:15 -0400 Message-ID: <4E93F4FC.4090303@redhat.com> Date: Tue, 11 Oct 2011 09:49:16 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1317069835-28815-1-git-send-email-lcapitulino@redhat.com> <4E932BB8.30305@redhat.com> <20111010172507.322ceda7@doriath> In-Reply-To: <20111010172507.322ceda7@doriath> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/6]: block: Add I/O status support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: zwu.kernel@gmail.com, armbru@redhat.com, qemu-devel@nongnu.org Am 10.10.2011 22:25, schrieb Luiz Capitulino: > On Mon, 10 Oct 2011 19:30:32 +0200 > Kevin Wolf wrote: > >> Am 26.09.2011 22:43, schrieb Luiz Capitulino: >>> This series adds support to the block layer to keep track of devices' >>> I/O status. That information is also made available in QMP and HMP. >>> >>> The goal here is to allow management applications that miss the >>> BLOCK_IO_ERROR event to able to query the VM to determine if any device has >>> caused the VM to stop and which device caused it. >>> >>> Here's an HMP example: >>> >>> (qemu) info status >>> VM status: paused (io-error) >>> (qemu) info block >>> ide0-hd0: removable=0 io-status=ok file=disks/test2.img ro=0 drv=qcow2 encrypted=0 >>> ide0-hd1: removable=0 io-status=nospace file=/dev/vg_doriath/kvmtest ro=0 drv=qcow2 encrypted=0 >>> ide1-cd0: removable=1 locked=0 io-status=ok [not inserted] >>> floppy0: removable=1 locked=0 [not inserted] >>> sd0: removable=1 locked=0 [not inserted] >>> >>> The session above shows that the VM is stopped due to an I/O error. By using >>> the info block command it's possible to determine that the 'ide0-hd1' device >>> caused the error, which turns out to be due to no space. >> >> Thanks, applied all to the block branch. > > This series will conflict with my "first round of qapi conversions" series. > > It seems to me that the conflicts are rather simple, just doing > s/RSTATE_/RUN_STATE should fix them, but I can resend the series if you think > that's better. Thanks for the heads-up. It seems to be a trivial conflict indeed and I resolved it myself. Kevin