From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37065)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RDY1V-0002Cr-TM
	for qemu-devel@nongnu.org; Tue, 11 Oct 2011 04:49:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RDY1V-00082r-1e
	for qemu-devel@nongnu.org; Tue, 11 Oct 2011 04:49:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8917)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RDY1U-00082g-QH
	for qemu-devel@nongnu.org; Tue, 11 Oct 2011 04:49:17 -0400
Message-ID: <4E940318.2040007@redhat.com>
Date: Tue, 11 Oct 2011 10:49:28 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1316621468-32171-1-git-send-email-marcandre.lureau@redhat.com>
	<1316621468-32171-8-git-send-email-marcandre.lureau@redhat.com>
In-Reply-To: <1316621468-32171-8-git-send-email-marcandre.lureau@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/11] audio/spice: add support for volume
 control
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= <marcandre.lureau@gmail.com>
Cc: =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org

   Hi,

> +#else
> +#warning "Spice playback volume unsupported"
> +#endif

> +#else
> +#warning "Spice record volume unsupported"
> +#endif

One warning is enougth.  But given that qemu builds with -Werror by 
default printing a warning just because of an older spice-server version 
is a bad idea IMHO.

> @@ -337,6 +379,7 @@ struct audio_driver spice_audio_driver = {
>       .max_voices_in  = 1,
>       .voice_size_out = sizeof (SpiceVoiceOut),
>       .voice_size_in  = sizeof (SpiceVoiceIn),
> +    .ctl_caps       = VOICE_VOLUME_CAP

This should be #ifdef'ed too I guess?

cheers,
   Gerd