From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDb0k-0007K1-Dh for qemu-devel@nongnu.org; Tue, 11 Oct 2011 08:00:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RDb0h-0003L2-BI for qemu-devel@nongnu.org; Tue, 11 Oct 2011 08:00:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDb0g-0003KF-Sv for qemu-devel@nongnu.org; Tue, 11 Oct 2011 08:00:39 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9BC0Z6L021518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 11 Oct 2011 08:00:36 -0400 Message-ID: <4E942FE1.1090902@redhat.com> Date: Tue, 11 Oct 2011 14:00:33 +0200 From: Dor Laor MIME-Version: 1.0 References: <21253396-fd2b-4bd2-afcf-2f5659347f5e@zmail02.collab.prod.int.phx2.redhat.com> In-Reply-To: <21253396-fd2b-4bd2-afcf-2f5659347f5e@zmail02.collab.prod.int.phx2.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu: new option for snapshot_blkdev to avoid image creation Reply-To: dlaor@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Federico Simoncelli Cc: Kevin Wolf , abaron@redhat.com, qemu-devel@nongnu.org On 10/11/2011 01:56 PM, Federico Simoncelli wrote: > ----- Original Message ----- >> From: "Dor Laor" >> To: "Federico Simoncelli" >> Cc: qemu-devel@nongnu.org, abaron@redhat.com, "Kevin Wolf" >> Sent: Friday, October 7, 2011 12:45:06 AM >> Subject: Re: [Qemu-devel] [PATCH] qemu: new option for snapshot_blkdev to avoid image creation >> >> On 10/03/2011 06:09 PM, Federico Simoncelli wrote: >>> Add the new option [-n] for snapshot_blkdev to avoid the image >>> creation. >>> The file provided as [new-image-file] is considered as already >>> initialized >>> and will be used after passing a check for the backing file. >> >> Seems ok to me as a way to go around fdget and still have selinux >> gain. >> Worth to get Kevin's view too. > > Hi Kevin, any news on this? > >> Federico, would you like to ack or extend the design: >> http://wiki.qemu.org/Features/Snapshots > > Dor, should I do it now or only after my patch is acked? We're not that strict in the OSS world ;) you can do it before and mark as a pending request. btw: Kevin is back so he will probably drain his queue soon.