From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47152)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RE1HA-0004e6-Fy
	for qemu-devel@nongnu.org; Wed, 12 Oct 2011 12:03:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RE1H4-0001Ar-PE
	for qemu-devel@nongnu.org; Wed, 12 Oct 2011 12:03:24 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:33897)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RE1H4-0001A3-J5
	for qemu-devel@nongnu.org; Wed, 12 Oct 2011 12:03:18 -0400
Message-ID: <4E95BA25.3070804@web.de>
Date: Wed, 12 Oct 2011 18:02:45 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <cover.1317971994.git.jan.kiszka@siemens.com>
	<f6f366b86bc76d653e28239e7da67165954b8617.1317971994.git.jan.kiszka@siemens.com>
In-Reply-To: <f6f366b86bc76d653e28239e7da67165954b8617.1317971994.git.jan.kiszka@siemens.com>
Content-Type: text/plain; charset=UTF-8
Sender: andreas.faerber@web.de
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 16/23] i8259: PREP: Replace
 pic_intack_read with pic_read_irq
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, hpoussin@reactos.org, qemu-devel <qemu-devel@nongnu.org>

Hello Jan,

Since the last round of pulls, PReP magically boots again. :)

Am 07.10.2011 09:19, schrieb Jan Kiszka:
> There is nothing in the i8259 spec that justifies the special
> pic_intack_read. At least the Linux PREP kernels configure the PICs
> properly so that pic_read_irq returns identical values, and setting
> read_reg_select in PIC0 cannot be derived from any special i8259 mode.
>=20
> So switch ppc_prep to pic_read_irq and drop the now unused PIC code.

Seems to resolve an existing XXX in the code.

> CC: Andreas F=C3=A4rber <andreas.faerber@web.de>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Linux is the only thing we can boot with -M prep that I'm aware of, via
-kernel. And the 40p series doesn't use this at all. I see no regression
on my Debian Etch, so I'm fine with the simplification.

Tested-by: Andreas F=C3=A4rber <andreas.faerber@web.de>

> diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c
> index d26049b..6427baa 100644
> --- a/hw/ppc_prep.c
> +++ b/hw/ppc_prep.c
> @@ -130,7 +130,7 @@ static inline uint32_t _PPC_intack_read(target_phys=
_addr_t addr)
>      uint32_t retval =3D 0;
> =20
>      if ((addr & 0xf) =3D=3D 0)
> -        retval =3D pic_intack_read(isa_pic);
> +        retval =3D pic_read_irq(isa_pic);

Mind to add the braces while touching it?

Regards,
Andreas