From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RE1VA-0002If-Fm for qemu-devel@nongnu.org; Wed, 12 Oct 2011 12:17:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RE1V8-0004hP-Ss for qemu-devel@nongnu.org; Wed, 12 Oct 2011 12:17:52 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60500 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RE1V8-0004ga-O3 for qemu-devel@nongnu.org; Wed, 12 Oct 2011 12:17:50 -0400 Message-ID: <4E95BDAC.6030308@suse.de> Date: Wed, 12 Oct 2011 18:17:48 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1318406014-16911-1-git-send-email-mohan@in.ibm.com> In-Reply-To: <1318406014-16911-1-git-send-email-mohan@in.ibm.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] Add opt_set_bool function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "M. Mohan Kumar" Cc: qemu-devel@nongnu.org Am 12.10.2011 09:53, schrieb M. Mohan Kumar: > In addition to qemu_opt_set function, we need a function to set bool va= lue > also. > > Signed-off-by: M. Mohan Kumar > --- > qemu-option.c | 35 +++++++++++++++++++++++++++++++++++ > qemu-option.h | 1 + > 2 files changed, 36 insertions(+), 0 deletions(-) > > diff --git a/qemu-option.c b/qemu-option.c > index 105d760..d6bc908 100644 > --- a/qemu-option.c > +++ b/qemu-option.c > @@ -636,6 +636,41 @@ int qemu_opt_set(QemuOpts *opts, const char *name,= const char *value) > return 0; > } > > +int qemu_opt_set_bool(QemuOpts *opts, const char *name, int val) Might it make sense to let qemu_opt_{get,set}_bool() use bool type? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746, AG N=FCrnb= erg