From: Stefan Weil <sw@weilnetz.de>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Anthony Liguori <anthony@codemonkey.ws>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Buggy SDL Zoom
Date: Wed, 12 Oct 2011 23:01:45 +0200 [thread overview]
Message-ID: <4E960039.5030607@weilnetz.de> (raw)
Hi,
the SDL zoom feature which is implemented in sdl_zoom_template.h
(and the SDL_rotozoom version which it is based on) accesses memory
beyond the allocated limits.
This can be easily reproduced using Valgrind and some Linux desktop
which resizes QEMU's window to fill the whole screen (I did run the tests
on an Ubuntu netbook).
Another effect can be observed by repeatedly increasing the zoom factor
with the Alt-Ctrl-+: the image grows up to a certain value and then
collapses again.
It looks like other programs using SDL_rotozoom also discovered
out-of-bound problems, and in newer versions, the SDL_rotozoom
code was totally rewritten.
For security reasons, I suggest disabling the zoom feature until
either the current code is replaced by a (tested) newer version
of SDL_rotozoom or fixed.
Cheers,
Stefan Weil
next reply other threads:[~2011-10-12 21:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 21:01 Stefan Weil [this message]
2011-10-13 11:50 ` [Qemu-devel] Buggy SDL Zoom Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E960039.5030607@weilnetz.de \
--to=sw@weilnetz.de \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).