From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REBg2-0000Xn-Br for qemu-devel@nongnu.org; Wed, 12 Oct 2011 23:09:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1REBg1-0000ZL-CH for qemu-devel@nongnu.org; Wed, 12 Oct 2011 23:09:46 -0400 Message-ID: <4E965650.90807@linux.vnet.ibm.com> Date: Thu, 13 Oct 2011 11:09:04 +0800 From: Dong Xu Wang MIME-Version: 1.0 References: <1317965926-1696-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1317965926-1696-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qemu-char: Fix use of free() instead of g_free() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org =D3=DA 10/07/2011 01:38 PM, Stefan Weil =D0=B4=B5=C0: > cppcheck reported these errors: >=20 > qemu-char.c:1667: error: Mismatching allocation and deallocation: s > qemu-char.c:1668: error: Mismatching allocation and deallocation: chr > qemu-char.c:1769: error: Mismatching allocation and deallocation: s > qemu-char.c:1770: error: Mismatching allocation and deallocation: chr >=20 > Signed-off-by: Stefan Weil > --- > qemu-char.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/qemu-char.c b/qemu-char.c > index 09d2309..e1b2b87 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -1664,8 +1664,8 @@ static int qemu_chr_open_win(QemuOpts *opts, Char= DriverState **_chr) > chr->chr_close =3D win_chr_close; >=20 > if (win_chr_init(chr, filename)< 0) { > - free(s); > - free(chr); > + g_free(s); > + g_free(chr); > return -EIO; > } > qemu_chr_generic_open(chr); > @@ -1766,8 +1766,8 @@ static int qemu_chr_open_win_pipe(QemuOpts *opts,= CharDriverState **_chr) > chr->chr_close =3D win_chr_close; >=20 > if (win_chr_pipe_init(chr, filename)< 0) { > - free(s); > - free(chr); > + g_free(s); > + g_free(chr); > return -EIO; > } > qemu_chr_generic_open(chr); Tested-by: Dongxu Wang