From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REG2P-0008Gn-Ge for qemu-devel@nongnu.org; Thu, 13 Oct 2011 03:49:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1REG2O-0000jJ-NU for qemu-devel@nongnu.org; Thu, 13 Oct 2011 03:49:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REG2O-0000is-GX for qemu-devel@nongnu.org; Thu, 13 Oct 2011 03:49:08 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9D7n6Jr015426 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 13 Oct 2011 03:49:06 -0400 Message-ID: <4E969801.9060106@redhat.com> Date: Thu, 13 Oct 2011 09:49:21 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <20111011183036.GL1049@bow.tlv.redhat.com> <1318437328-16865-1-git-send-email-cfergeau@redhat.com> <20111012164742.GA18741@teriyaki.cdg.redhat.com> In-Reply-To: <20111012164742.GA18741@teriyaki.cdg.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ps2: migrate ledstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christophe Fergeau Cc: qemu-devel@nongnu.org Hi, > One thing that could be improved after this patch is that the ledstate > is now present both in spice-input and hw/ps2.c, but I couldn't find > an easy way to get the ps2 ledstate from spice-input so I left things > this way for now. Directly linking ps/2 and spice-input would be wrong anyway as there are other keyboards (usb) too ... input.c could cache the ledstate and offer a kbd_get_ledstate function, so anyone interested in the state doesn't need to keep it itself. That is a pretty minor thing though IMHO. cheers, Gerd