From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REGTy-0005WD-L6 for qemu-devel@nongnu.org; Thu, 13 Oct 2011 04:17:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1REGTu-0006Ts-DF for qemu-devel@nongnu.org; Thu, 13 Oct 2011 04:17:38 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:34169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REGTt-0006TM-Mp for qemu-devel@nongnu.org; Thu, 13 Oct 2011 04:17:34 -0400 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by e28smtp06.in.ibm.com (8.14.4/8.13.1) with ESMTP id p9D8HT87007183 for ; Thu, 13 Oct 2011 13:47:29 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p9D8GvwD3870888 for ; Thu, 13 Oct 2011 13:47:29 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p9D8FYK5021280 for ; Thu, 13 Oct 2011 13:46:56 +0530 Message-ID: <4E969D10.4060808@vnet.linux.ibm.com> Date: Thu, 13 Oct 2011 16:10:56 +0800 From: Mark Wu MIME-Version: 1.0 References: <1318439659-7525-1-git-send-email-wudxw@linux.vnet.ibm.com> In-Reply-To: <1318439659-7525-1-git-send-email-wudxw@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] trace: Add support for trace events grouping List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Wu Cc: Stefan Hajnoczi , qemu-devel@nongnu.org On 10/13/2011 01:14 AM, Mark Wu wrote: > This series add support for trace events grouping. The state of a given group > of trace events can be queried or changed in bulk by the following monitor > commands: > > * info trace-groups > View available trace event groups and their state. State 1 means enabled, > state 0 means disabled. > > * trace-group NAME on|off > Enable/disable a given trace event group. > > A group of trace events can also be enabled in early running stage through > adding its group name prefixed with "group:" to trace events list file > which is passed to "-trace events". > > Mark Wu (6): > trace: Make "tracetool" generate a group list > trace: Add HMP monitor commands for trace events group > trace: Add trace events group implementation in the backend "simple" > trace: Add trace events group implementation in the backend "stderr" > trace: Enable "-trace events" argument to control initial state of > groups > trace: Update doc for trace events group > > docs/tracing.txt | 29 ++++++++++++++-- > hmp-commands.hx | 14 ++++++++ > monitor.c | 22 ++++++++++++ > scripts/tracetool | 94 +++++++++++++++++++++++++++++++++++++++++++++++++++- > trace-events | 88 +++++++++++++++++++++++++++++++++++++++++++++++++ > trace/control.c | 17 +++++++++ > trace/control.h | 9 +++++ > trace/default.c | 15 ++++++++ > trace/simple.c | 30 +++++++++++++++++ > trace/simple.h | 7 ++++ > trace/stderr.c | 32 ++++++++++++++++++ > trace/stderr.h | 7 ++++ > 12 files changed, 359 insertions(+), 5 deletions(-) > Sorry, there're some coding style problems in the patches. I have fixed them and will send out later in order to see if there's any other problem coming up. :)