From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Huth <thuth@linux.vnet.ibm.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [BUG] USB assertion triggers in usb_packet_complete()
Date: Thu, 13 Oct 2011 12:51:51 +0200 [thread overview]
Message-ID: <4E96C2C7.7060605@redhat.com> (raw)
In-Reply-To: <20111012131720.11e8520f@BR8GGW75.de.ibm.com>
Hi,
>> Hi Thomas,
>> I hit the same bug recently and Gerd has posted a patch which you can test:
>> http://patchwork.ozlabs.org/patch/118726/
>
> Thanks for the hint, Stefan, you're right, that seems to be the same
> bug. Your patch is working fine in my scenario, too.
>
> However, Gerd's patch is not working for me, the assertion still
> triggers. It seems like usb_packet_complete() is called for the leaf
> node before it is called for the hub node, so the leaf node already set
> p->owner = NULL.
Ah, right, on completion the call chain goes the other way around, so
the usb_handle_packet() style approach doesn't fly.
I think going with Stefans approach + a big fat comment is the best
solution then. I'll go queue up a patch.
cheers,
Gerd
prev parent reply other threads:[~2011-10-13 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 13:03 [Qemu-devel] [BUG] USB assertion triggers in usb_packet_complete() Thomas Huth
2011-10-11 7:35 ` Thomas Huth
2011-10-12 10:02 ` Stefan Hajnoczi
2011-10-12 11:17 ` Thomas Huth
2011-10-13 10:51 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E96C2C7.7060605@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=thuth@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).