From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REJYi-0003K5-KJ for qemu-devel@nongnu.org; Thu, 13 Oct 2011 07:34:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1REJYc-0003IB-UJ for qemu-devel@nongnu.org; Thu, 13 Oct 2011 07:34:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47613) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REJYc-0003Hd-L6 for qemu-devel@nongnu.org; Thu, 13 Oct 2011 07:34:38 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9DBYbZK011926 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 13 Oct 2011 07:34:37 -0400 Message-ID: <4E96CCDD.5050208@redhat.com> Date: Thu, 13 Oct 2011 13:34:53 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1318504111-15309-1-git-send-email-kraxel@redhat.com> <1318504111-15309-10-git-send-email-kraxel@redhat.com> In-Reply-To: <1318504111-15309-10-git-send-email-kraxel@redhat.com> Content-Type: multipart/mixed; boundary="------------070301090908060609040707" Subject: Re: [Qemu-devel] [PATCH 9/9] usb-hub: don't trigger assert on packet completion. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------070301090908060609040707 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, > - usb_packet_complete(&s->dev, packet); > + s->dev.port->ops->complete(&s->dev.port, packet); Oops, that doesn't compile. Got sidetracked wile waiting for the test build finish, then forgot to check the results :( Updated patch attached. Branch for pulling updated inplace. cheers, Gerd --------------070301090908060609040707 Content-Type: text/plain; name="0001-usb-hub-don-t-trigger-assert-on-packet-completion.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-usb-hub-don-t-trigger-assert-on-packet-completion.patch" RnJvbSA4MGNmN2NmNzRmMjlhMjE5ZTAyYjUwZjI3YzEyYjFjNzkyZWJmOTliIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNv bT4KRGF0ZTogVGh1LCAxMyBPY3QgMjAxMSAxMjo1Mjo0NyArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIHVzYi1odWI6IGRvbid0IHRyaWdnZXIgYXNzZXJ0IG9uIHBhY2tldCBjb21wbGV0aW9u LgoKQ2FsbGluZyB1c2JfcGFja2V0X2NvbXBsZXRlKCkgcmVjdXJzaXZlbHkgd2hlbiBwYXNz aW5nIHVwIHRoZSBjb21wbGV0aW9uCmV2ZW50IHVwIHRoZSBjaGFpbiBmb3IgZGV2aWNlcyBj b25uZWN0ZWQgdmlhIHVzYiBodWIgd2lsbCB0cmlnZ2VyIGFuCmFzc2VydC4gIFNvIGRvbid0 IGRvIHRoYXQsIG1ha2UgdGhlIHVzYiBodWIgZW11bGF0aW9uIGNhbGwgdGhlIHVwc3RyZWFt CmNvbXBsZXRpb24gY2FsbGJhY2sgZGlyZWN0bHkgaW5zdGVhZC4KCkJhc2VkIG9uIGEgcGF0 Y2ggZnJvbSBTdGVmYW4gSGFqbm9jemkgPHN0ZWZhbmhhQGdtYWlsLmNvbT4KClNpZ25lZC1v ZmYtYnk6IEdlcmQgSG9mZm1hbm4gPGtyYXhlbEByZWRoYXQuY29tPgotLS0KIGh3L3VzYi1o dWIuYyB8ICAgIDggKysrKysrLS0KIDEgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2h3L3VzYi1odWIuYyBiL2h3L3VzYi1o dWIuYwppbmRleCAzOTM4MmM3Li4wOWM2NTE2IDEwMDY0NAotLS0gYS9ody91c2ItaHViLmMK KysrIGIvaHcvdXNiLWh1Yi5jCkBAIC0yMDcsMTAgKzIwNywxNCBAQCBzdGF0aWMgdm9pZCB1 c2JfaHViX2NvbXBsZXRlKFVTQlBvcnQgKnBvcnQsIFVTQlBhY2tldCAqcGFja2V0KQogICAg IC8qCiAgICAgICogSnVzdCBwYXNzIGl0IGFsb25nIHVwc3RyZWFtIGZvciBub3cuCiAgICAg ICoKLSAgICAgKiBJZiB3ZSBldmVyIGlucGxlbWVudCB1c2IgMi4wIHNwbGl0IHRyYW5zYWN0 aW9ucyB0aGlzIHdpbGwKKyAgICAgKiBJZiB3ZSBldmVyIGltcGxlbWVudCB1c2IgMi4wIHNw bGl0IHRyYW5zYWN0aW9ucyB0aGlzIHdpbGwKICAgICAgKiBiZWNvbWUgYSBsaXR0bGUgbW9y ZSBjb21wbGljYXRlZCAuLi4KKyAgICAgKgorICAgICAqIENhbid0IHVzZSB1c2JfcGFja2V0 X2NvbXBsZXRlKCkgaGVyZSBiZWNhdXNlIHBhY2tldC0+b3duZXIgaXMKKyAgICAgKiBjbGVh cmVkIGFscmVhZHksIGdvIGNhbGwgdGhlIC0+Y29tcGxldGUoKSBjYWxsYmFjayBkaXJlY3Rs eQorICAgICAqIGluc3RlYWQuCiAgICAgICovCi0gICAgdXNiX3BhY2tldF9jb21wbGV0ZSgm cy0+ZGV2LCBwYWNrZXQpOworICAgIHMtPmRldi5wb3J0LT5vcHMtPmNvbXBsZXRlKHMtPmRl di5wb3J0LCBwYWNrZXQpOwogfQogCiBzdGF0aWMgdm9pZCB1c2JfaHViX2hhbmRsZV9yZXNl dChVU0JEZXZpY2UgKmRldikKLS0gCjEuNy4xCgo= --------------070301090908060609040707--