From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REdPS-0003q0-9T for qemu-devel@nongnu.org; Fri, 14 Oct 2011 04:46:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1REdPR-0003AE-7W for qemu-devel@nongnu.org; Fri, 14 Oct 2011 04:46:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6785) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REdPQ-0003A5-VZ for qemu-devel@nongnu.org; Fri, 14 Oct 2011 04:46:29 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9E8kQYW025597 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 14 Oct 2011 04:46:28 -0400 Message-ID: <4E97F79A.1040609@redhat.com> Date: Fri, 14 Oct 2011 10:49:30 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <20111013172753.3b744c58@doriath> In-Reply-To: <20111013172753.3b744c58@doriath> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Paolo Bonzini , qemu-devel Am 13.10.2011 22:27, schrieb Luiz Capitulino: > qemu_savevm_state() has some logic to stop the VM and to (or not to) > resume it. But this seems to be a big noop, as qemu_savevm_state() > is only called by do_savevm() when the VM is already stopped. > > So, let's drop qemu_savevm_state()'s stop VM logic. > > Signed-off-by: Luiz Capitulino Reviewed-by: Kevin Wolf