From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REfaJ-0001gE-So for qemu-devel@nongnu.org; Fri, 14 Oct 2011 07:05:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1REfaE-00076K-Al for qemu-devel@nongnu.org; Fri, 14 Oct 2011 07:05:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REfaE-000769-3f for qemu-devel@nongnu.org; Fri, 14 Oct 2011 07:05:46 -0400 Message-ID: <4E98183E.5040303@redhat.com> Date: Fri, 14 Oct 2011 13:08:46 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1318581692-18338-1-git-send-email-pbonzini@redhat.com> <1318581692-18338-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1318581692-18338-3-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 14.10.2011 10:41, schrieb Paolo Bonzini: > Add coroutine support for flush and apply the same emulation that > we already do for read/write. bdrv_aio_flush is simplified to always > go through a coroutine. > > Signed-off-by: Paolo Bonzini To make the implementation more consistent with read/write operations, wouldn't it make sense to provide a bdrv_co_flush() globally instead of using the synchronous version as the preferred public interface? This is the semantics that I would expect of a bdrv_co_flush() anyway, your use of it for an AIO emulation functions confused me a bit at first. Kevin