From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REhO1-0004c6-4Y for qemu-devel@nongnu.org; Fri, 14 Oct 2011 09:01:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1REhNv-0007sY-BE for qemu-devel@nongnu.org; Fri, 14 Oct 2011 09:01:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52849) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REhNv-0007sQ-0z for qemu-devel@nongnu.org; Fri, 14 Oct 2011 09:01:11 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9ED19Gx016169 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 14 Oct 2011 09:01:10 -0400 Message-ID: <4E9832A4.3020802@redhat.com> Date: Fri, 14 Oct 2011 15:01:24 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1316694826-20568-1-git-send-email-alevy@redhat.com> In-Reply-To: <1316694826-20568-1-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qxl: create slots on post_load in any state (fix RHBZ 740547) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On 09/22/11 14:33, Alon Levy wrote: > If we migrate when the device is not in a native state the guest > still believes the slots are created, and will cause operations > that reference the slots, causing a "panic: virtual address out of range" > on the first of them. Easy to see by migrating in vga mode (with > a driver loaded, for instance windows cmd window in full screen mode) > and then exiting vga mode back to native mode will cause said panic. > > Fixed by doing the slot recreation unconditionally at post_load Added to spice patch queue. thanks, Gerd