From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REid9-00083G-VU for qemu-devel@nongnu.org; Fri, 14 Oct 2011 10:21:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1REid5-0002M3-BA for qemu-devel@nongnu.org; Fri, 14 Oct 2011 10:20:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REid4-0002Ln-Tp for qemu-devel@nongnu.org; Fri, 14 Oct 2011 10:20:55 -0400 Message-ID: <4E9845E6.3020905@redhat.com> Date: Fri, 14 Oct 2011 16:23:34 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1318581692-18338-1-git-send-email-pbonzini@redhat.com> <1318581692-18338-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1318581692-18338-5-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 14.10.2011 10:41, schrieb Paolo Bonzini: > This similarly adds support for coroutine and asynchronous discard. > > Signed-off-by: Paolo Bonzini Do we really need bdrv_discard and bdrv_aio_discard in the backends? I think it makes sense to have a bdrv_aio_discard() in block.h as AIO generally fits well for device models, but I would just require bdrv_co_discard for any block drivers implementing discard. > I was not sure if qcow2 could be changed to co_discard, though > I suspected yes. As discussed on IRC: Yes, it just must make sure to take s->lock. Kevin