From: Jan Kiszka <jan.kiszka@web.de>
To: malc <av1474@comtv.ru>
Cc: "Blue Swirl" <blauwirbel@gmail.com>,
"Anthony Liguori" <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Andreas Färber" <andreas.faerber@web.de>
Subject: Re: [Qemu-devel] [PATCH v2 00/23] Rework i8259 and PC interrupt models
Date: Sun, 16 Oct 2011 14:22:44 +0200 [thread overview]
Message-ID: <4E9ACC94.2080505@web.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1110161605590.1861@linmac>
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
On 2011-10-16 14:07, malc wrote:
> On Sun, 16 Oct 2011, Blue Swirl wrote:
>
>> Thanks, applied all.
>>
>> On Fri, Oct 7, 2011 at 7:19 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>> Highlights of this series:
>>> - generic i8259, now part of hwlib
>>> - qdev conversion of i8259
>>> - fix for i8259 poll mode (and removal of PREP hack)
>>>
>>> The refactoring will also be important to instantiate i8259-kvm devices
>>> for in-kernel irqchip acceleration one day.
>>>
>>> Changes in v2:
>>> - kept PIC irq state update after reset but clarified why this
>>> required and only valid here
>>> - additional fix: Clear ELCR on reset
>
> It's not cleared on reset on real hardware..
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg04569.html
It is, see Intel chipset specs.
It is not cleared - and that was likely the bug you once saw - when only
the PIC goes through reset, triggered via an ICWS. But that is handled
as a separate case now, no need to worry.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
prev parent reply other threads:[~2011-10-16 12:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 7:19 [Qemu-devel] [PATCH v2 00/23] Rework i8259 and PC interrupt models Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 01/23] pc: Drop useless test from isa_irq_handler Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 02/23] pc: Generalize ISA IRQs to GSIs Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 03/23] pc: Convert GSIState::i8259_irq into array Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 04/23] pc: Fix and clean up PIC-to-APIC IRQ path Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 05/23] i8259: Remove premature inline function attributes Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 06/23] i8259: Drop obsolete prototypes Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 07/23] i8259: Move pic_set_irq1 after pic_update_irq Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 08/23] i8239: Introduce per-PIC output interrupt Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 09/23] i8259: Do not update IRQ output after spurious pic_poll_read Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 10/23] i8259: Reorder intack in pic_read_irq Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 11/23] i8259: Update IRQ state after reset Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 12/23] i8259: Clear ELCR on reset Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 13/23] i8259: Switch to per-PIC IRQ update Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 14/23] i8259: Fix poll command Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 15/23] i8259: Clean up pic_ioport_read Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 16/23] i8259: PREP: Replace pic_intack_read with pic_read_irq Jan Kiszka
2011-10-12 16:02 ` Andreas Färber
2011-10-12 16:10 ` Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 17/23] i8259: Replace PicState::pics_state with master flag Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 18/23] i8259: Eliminate PicState2 Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 19/23] qdev: Add HEX8 property Jan Kiszka
2011-10-07 8:39 ` Andreas Färber
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 20/23] i8259: Convert to qdev Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 21/23] i8259: Fix coding style Jan Kiszka
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 22/23] monitor: Restrict pic/irq_info to supporting targets Jan Kiszka
2011-10-16 9:53 ` [Qemu-devel] [PATCH v3 " Jan Kiszka
2011-10-18 23:07 ` Andreas Färber
2011-10-07 7:19 ` [Qemu-devel] [PATCH v2 23/23] i8259: Move to hw library Jan Kiszka
2011-10-16 9:53 ` [Qemu-devel] [PATCH v3 " Jan Kiszka
2011-10-15 21:01 ` [Qemu-devel] [PATCH v2 00/23] Rework i8259 and PC interrupt models Blue Swirl
2011-10-16 12:03 ` Blue Swirl
2011-10-16 12:07 ` malc
2011-10-16 12:22 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9ACC94.2080505@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=andreas.faerber@web.de \
--cc=av1474@comtv.ru \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).