qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv3] ps2: migrate ledstate
Date: Mon, 17 Oct 2011 11:25:42 +0200	[thread overview]
Message-ID: <4E9BF496.3000908@redhat.com> (raw)
In-Reply-To: <1318607068-17700-1-git-send-email-cfergeau@redhat.com>

>
>   static const VMStateDescription vmstate_ps2_common = {
>       .name = "PS2 Common State",
> -    .version_id = 3,
> +    .version_id = 4,
>       .minimum_version_id = 2,
>       .minimum_version_id_old = 2,
>       .fields      = (VMStateField []) {

> @@ -577,6 +585,7 @@ static const VMStateDescription vmstate_ps2_keyboard = {
>           VMSTATE_INT32(scan_enabled, PS2KbdState),
>           VMSTATE_INT32(translate, PS2KbdState),
>           VMSTATE_INT32_V(scancode_set, PS2KbdState,3),
> +        VMSTATE_INT32_V(ledstate, PS2KbdState, 4),
>           VMSTATE_END_OF_LIST()
>       }

version_id in vmstate_ps2_keyboard must be updated too.

The version update in vmstate_ps2_common might not be needed, IIRC the 
versions for stuff referenced via VMSTATE_STRUCT() isn't used anyway, Juan?

cheers,
   Gerd

  reply	other threads:[~2011-10-17  9:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-11 16:28 [Qemu-devel] [PATCH] spice-input: migrate ledstate Alon Levy
2011-10-11 18:23 ` Anthony Liguori
2011-10-11 18:30   ` Alon Levy
2011-10-12  7:45     ` Gerd Hoffmann
2011-10-12 16:35     ` [Qemu-devel] [PATCH] ps2: " Christophe Fergeau
2011-10-12 16:42       ` Anthony Liguori
2011-10-12 17:17         ` [Qemu-devel] [PATCHv2] " Christophe Fergeau
2011-10-14 15:44           ` [Qemu-devel] [PATCHv3] " Christophe Fergeau
2011-10-17  9:25             ` Gerd Hoffmann [this message]
2011-10-17 10:10               ` Christophe Fergeau
2011-10-12 16:47       ` [Qemu-devel] [PATCH] " Christophe Fergeau
2011-10-13  7:49         ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9BF496.3000908@redhat.com \
    --to=kraxel@redhat.com \
    --cc=cfergeau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).