From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56063)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RFjRs-0003l9-Ob
	for qemu-devel@nongnu.org; Mon, 17 Oct 2011 05:25:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RFjRr-0003hD-Jx
	for qemu-devel@nongnu.org; Mon, 17 Oct 2011 05:25:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43371)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RFjRr-0003gz-9G
	for qemu-devel@nongnu.org; Mon, 17 Oct 2011 05:25:31 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9H9PTEt026172
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 17 Oct 2011 05:25:30 -0400
Message-ID: <4E9BF496.3000908@redhat.com>
Date: Mon, 17 Oct 2011 11:25:42 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1318439877-26376-1-git-send-email-cfergeau@redhat.com>
	<1318607068-17700-1-git-send-email-cfergeau@redhat.com>
In-Reply-To: <1318607068-17700-1-git-send-email-cfergeau@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv3] ps2: migrate ledstate
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

>
>   static const VMStateDescription vmstate_ps2_common = {
>       .name = "PS2 Common State",
> -    .version_id = 3,
> +    .version_id = 4,
>       .minimum_version_id = 2,
>       .minimum_version_id_old = 2,
>       .fields      = (VMStateField []) {

> @@ -577,6 +585,7 @@ static const VMStateDescription vmstate_ps2_keyboard = {
>           VMSTATE_INT32(scan_enabled, PS2KbdState),
>           VMSTATE_INT32(translate, PS2KbdState),
>           VMSTATE_INT32_V(scancode_set, PS2KbdState,3),
> +        VMSTATE_INT32_V(ledstate, PS2KbdState, 4),
>           VMSTATE_END_OF_LIST()
>       }

version_id in vmstate_ps2_keyboard must be updated too.

The version update in vmstate_ps2_common might not be needed, IIRC the 
versions for stuff referenced via VMSTATE_STRUCT() isn't used anyway, Juan?

cheers,
   Gerd