From: Kevin Wolf <kwolf@redhat.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: pair@us.ibm.com, stefanha@linux.vnet.ibm.com,
kvm@vger.kernel.org, mtosatti@redhat.com,
Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>,
aliguori@us.ibm.com, qemu-devel@nongnu.org, ryanh@us.ibm.com
Subject: Re: [Qemu-devel] [PATCH v8 2/4] block: add the command line support
Date: Mon, 17 Oct 2011 12:19:46 +0200 [thread overview]
Message-ID: <4E9C0142.3030107@redhat.com> (raw)
In-Reply-To: <CAEH94Lg8MPXs=QG=YmFDTQGgqeP7p+mFELtHZeChU=ccGFoWDw@mail.gmail.com>
Am 26.09.2011 08:15, schrieb Zhi Yong Wu:
> On Fri, Sep 23, 2011 at 11:54 PM, Kevin Wolf <kwolf@redhat.com> wrote:
>>> +}
>>> +
>>> +static void bdrv_block_timer(void *opaque)
>>> +{
>>> + BlockDriverState *bs = opaque;
>>> + BlockQueue *queue = bs->block_queue;
>>> +
>>> + qemu_block_queue_flush(queue);
>>
>> Hm, didn't really notice it while reading patch 1, but
>> qemu_block_queue_flush() is misleading. It's really something like
> Why do you say this is misleading?
>> qemu_block_queue_submit().
> Right. It will resubmit all enqueued I/O requests.
For me, flush sounds as if it waits for completion of all requests.
Kevin
next prev parent reply other threads:[~2011-10-17 10:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 10:11 [Qemu-devel] [PATCH v8 0/4] The intro of QEMU block I/O throttling Zhi Yong Wu
2011-09-08 10:11 ` [Qemu-devel] [PATCH v8 1/4] block: add the block queue support Zhi Yong Wu
2011-09-23 15:32 ` Kevin Wolf
2011-09-26 8:01 ` Zhi Yong Wu
2011-10-17 10:17 ` Kevin Wolf
[not found] ` <4E9C00D2.1040004@redhat.com>
2011-10-18 7:00 ` Zhi Yong Wu
2011-10-18 8:07 ` Zhi Yong Wu
2011-10-18 8:36 ` Kevin Wolf
2011-10-18 9:29 ` Zhi Yong Wu
2011-10-18 9:56 ` Kevin Wolf
2011-10-18 13:29 ` Zhi Yong Wu
2011-09-08 10:11 ` [Qemu-devel] [PATCH v8 2/4] block: add the command line support Zhi Yong Wu
2011-09-23 15:54 ` Kevin Wolf
2011-09-26 6:15 ` Zhi Yong Wu
2011-10-17 10:19 ` Kevin Wolf [this message]
2011-10-18 8:17 ` Zhi Yong Wu
2011-09-08 10:11 ` [Qemu-devel] [PATCH v8 3/4] block: add block timer and throttling algorithm Zhi Yong Wu
2011-09-09 14:44 ` Marcelo Tosatti
2011-09-13 3:09 ` Zhi Yong Wu
2011-09-14 10:50 ` Marcelo Tosatti
2011-09-19 9:55 ` Zhi Yong Wu
2011-09-20 12:34 ` Marcelo Tosatti
2011-09-21 3:14 ` Zhi Yong Wu
2011-09-21 5:54 ` Zhi Yong Wu
2011-09-21 7:03 ` Zhi Yong Wu
2011-09-26 8:15 ` Zhi Yong Wu
2011-09-23 16:19 ` Kevin Wolf
2011-09-26 7:24 ` Zhi Yong Wu
2011-10-17 10:26 ` Kevin Wolf
2011-10-17 15:54 ` Stefan Hajnoczi
2011-10-18 8:29 ` Zhi Yong Wu
2011-10-18 8:43 ` Zhi Yong Wu
2011-09-08 10:11 ` [Qemu-devel] [PATCH v8 4/4] qmp/hmp: add block_set_io_throttle Zhi Yong Wu
-- strict thread matches above, loose matches on Subject: below --
2011-09-07 12:31 [Qemu-devel] [PATCH v8 0/4] The intro of QEMU block I/O throttling Zhi Yong Wu
2011-09-07 12:31 ` [Qemu-devel] [PATCH v8 2/4] block: add the command line support Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9C0142.3030107@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pair@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@us.ibm.com \
--cc=stefanha@linux.vnet.ibm.com \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).