From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFlK4-0002lo-E7 for qemu-devel@nongnu.org; Mon, 17 Oct 2011 07:25:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RFlJz-0002hF-1O for qemu-devel@nongnu.org; Mon, 17 Oct 2011 07:25:36 -0400 Received: from thoth.sbs.de ([192.35.17.2]:27721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFlJy-0002h7-Lv for qemu-devel@nongnu.org; Mon, 17 Oct 2011 07:25:30 -0400 Message-ID: <4E9C10A8.4060706@siemens.com> Date: Mon, 17 Oct 2011 13:25:28 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <76a09d29c3ff24930642b36302ce41dd96824ca1.1318843693.git.jan.kiszka@siemens.com> <4E9C0DF5.8050209@redhat.com> In-Reply-To: <4E9C0DF5.8050209@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH 17/45] qemu-kvm: Track MSIRoutingCache in KVM routing table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Alex Williamson , Marcelo Tosatti , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "Michael S. Tsirkin" On 2011-10-17 13:13, Avi Kivity wrote: > On 10/17/2011 11:27 AM, Jan Kiszka wrote: >> Keep a link from the internal KVM routing table to potential MSI routing >> cache entries. The link is used so far whenever the entry is dropped to >> invalidate the cache content. It will allow us to build MSI routing >> entries on demand and flush existing ones on table overflow. >> > > Does this not require a destructor for MSIRoutingCache? Yes, kvm_msi_cache_invalidate. Cache providers are responsible for invalidating used caches before freeing them. That also drops the reference established here. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux