From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFlLy-0004tQ-Hr for qemu-devel@nongnu.org; Mon, 17 Oct 2011 07:27:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RFlLx-0003VE-LY for qemu-devel@nongnu.org; Mon, 17 Oct 2011 07:27:34 -0400 Received: from thoth.sbs.de ([192.35.17.2]:30181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFlLx-0003V8-8H for qemu-devel@nongnu.org; Mon, 17 Oct 2011 07:27:33 -0400 Message-ID: <4E9C1123.4070204@siemens.com> Date: Mon, 17 Oct 2011 13:27:31 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20111017112217.GC4537@redhat.com> In-Reply-To: <20111017112217.GC4537@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH 42/45] msix: Introduce msix_init_simple List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Alex Williamson , Marcelo Tosatti , Avi Kivity , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" On 2011-10-17 13:22, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 11:28:16AM +0200, Jan Kiszka wrote: >> Devices models are usually not interested in specifying MSI-X >> configuration details beyond the number of vectors to provide and the >> BAR number to use. Layout of an exclusively used BAR and its >> registration can also be handled centrally. >> >> This is the purpose of msix_init_simple. It provides handy services to >> the existing users. Future users like device assignment may require more >> detailed setup specification. For them we will (re-)introduce msix_init >> with the full list of configuration option (in contrast to the current >> code). >> >> Signed-off-by: Jan Kiszka > > Well, this seems a bit of a code churn then, doesn't it? > We are also discussing using memory BAR for virtio-pci for other > stuff besides MSI-X, so the last user of the _simple variant > will be ivshmem then? We will surely see more MSI-X users over the time. Not sure if they all mix their MSIX-X BARs with other stuff. But e.g. the e1000 variant I have here does not. So there should be users in the future. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux