From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59668)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RFngG-00012t-Ih
	for qemu-devel@nongnu.org; Mon, 17 Oct 2011 09:56:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RFngF-0001Pv-CT
	for qemu-devel@nongnu.org; Mon, 17 Oct 2011 09:56:40 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:57390)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RFngF-0001Pr-9y
	for qemu-devel@nongnu.org; Mon, 17 Oct 2011 09:56:39 -0400
Received: by ggnr5 with SMTP id r5so3748914ggn.4
	for <qemu-devel@nongnu.org>; Mon, 17 Oct 2011 06:56:38 -0700 (PDT)
Message-ID: <4E9C3414.60704@codemonkey.ws>
Date: Mon, 17 Oct 2011 08:56:36 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1318326683.git.quintela@redhat.com>
	<59b76df2ff78727551dfa45b02af2ca5e442d84b.1318326683.git.quintela@redhat.com>
In-Reply-To: <59b76df2ff78727551dfa45b02af2ca5e442d84b.1318326683.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/36] buffered_file: Use right "opaque"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On 10/11/2011 05:00 AM, Juan Quintela wrote:
> buffered_close 's' variable is of type QEMUFileBuffered, and
> wait_for_unfreeze() expect to receive a MigrationState, that
> 'coincidentaly' is s->opaque.
>
> Signed-off-by: Juan Quintela<quintela@redhat.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>   buffered_file.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/buffered_file.c b/buffered_file.c
> index bcdf04f..701b440 100644
> --- a/buffered_file.c
> +++ b/buffered_file.c
> @@ -176,7 +176,7 @@ static int buffered_close(void *opaque)
>       while (!s->has_error&&  s->buffer_size) {
>           buffered_flush(s);
>           if (s->freeze_output)
> -            s->wait_for_unfreeze(s);
> +            s->wait_for_unfreeze(s->opaque);
>       }
>
>       ret = s->close(s->opaque);