From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFnlY-00014U-HQ for qemu-devel@nongnu.org; Mon, 17 Oct 2011 10:02:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RFnlX-0002lf-1x for qemu-devel@nongnu.org; Mon, 17 Oct 2011 10:02:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFnlW-0002lO-Lg for qemu-devel@nongnu.org; Mon, 17 Oct 2011 10:02:06 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9HE25ad003081 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 Oct 2011 10:02:05 -0400 Message-ID: <4E9C3616.3070000@redhat.com> Date: Mon, 17 Oct 2011 16:05:10 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1318503845-11473-1-git-send-email-pbonzini@redhat.com> <1318503845-11473-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1318503845-11473-5-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/35] atapi: fill in AUDIO_CTL page correctly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Am 13.10.2011 13:03, schrieb Paolo Bonzini: > The page is not anymore in MMC, but at least keep the values sane. > > Signed-off-by: Paolo Bonzini > --- > hw/ide/atapi.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c > index 347c38d..10f161f 100644 > --- a/hw/ide/atapi.c > +++ b/hw/ide/atapi.c > @@ -731,6 +731,8 @@ static void cmd_mode_sense(IDEState *s, uint8_t *buf) > buf[7] = 0; > > /* Fill with CDROM audio volume */ > + buf[8] = 0x0e; 0x0e would be more readable if it was written as MODE_PAGE_AUDIO_CTL. > + buf[9] = 0x0e; And this is really the length. But I'm not sure if writing it as 24 - 10 would help a lot. > buf[17] = 0; > buf[19] = 0; > buf[21] = 0; Of course the same is true for the other pages, so it could be done for all of them on top. Or maybe you actually have included it later in the series? Kevin