From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFo57-0000L5-0w for qemu-devel@nongnu.org; Mon, 17 Oct 2011 10:22:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RFo51-0007ZK-FZ for qemu-devel@nongnu.org; Mon, 17 Oct 2011 10:22:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFo51-0007ZE-8a for qemu-devel@nongnu.org; Mon, 17 Oct 2011 10:22:15 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9HEME3l032325 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 Oct 2011 10:22:14 -0400 Message-ID: <4E9C3A13.7090809@redhat.com> Date: Mon, 17 Oct 2011 16:22:11 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1318503845-11473-1-git-send-email-pbonzini@redhat.com> <1318503845-11473-5-git-send-email-pbonzini@redhat.com> <4E9C3616.3070000@redhat.com> <4E9C35E8.9010907@redhat.com> <4E9C376D.2060808@redhat.com> In-Reply-To: <4E9C376D.2060808@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/35] atapi: fill in AUDIO_CTL page correctly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On 10/17/2011 04:10 PM, Kevin Wolf wrote: >> > Yes, the coincidence is ugly. > > Maybe we should define structs for the mode pages so that you have real > names instead of just offsets into the output buffer? Yeah, it would be nice to have a common place for all the structs defined by the SCSI spec (also the GET CONFIGURATION data is ugly). Paolo