From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFolx-0002cQ-5n for qemu-devel@nongnu.org; Mon, 17 Oct 2011 11:06:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RFolv-0000gd-Gj for qemu-devel@nongnu.org; Mon, 17 Oct 2011 11:06:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFolv-0000gW-9j for qemu-devel@nongnu.org; Mon, 17 Oct 2011 11:06:35 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9HF6Yv0026527 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 Oct 2011 11:06:34 -0400 Message-ID: <4E9C4478.2080704@redhat.com> Date: Mon, 17 Oct 2011 17:06:32 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1318503845-11473-1-git-send-email-pbonzini@redhat.com> <1318503845-11473-10-git-send-email-pbonzini@redhat.com> <4E9C4433.6090205@redhat.com> In-Reply-To: <4E9C4433.6090205@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/35] atapi/scsi-disk: make mode page values coherent between the two List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On 10/17/2011 05:05 PM, Kevin Wolf wrote: > If I understand correctly what the internet says (I don't have a copy of > MMC-3 and MMC-5 doesn't describe it any more), this is still part of the > volume. I'm not sure why we should provide exactly two different volume > levels, but if you think this makes sense, please change p[10] to be 2>> 8. Because "If the Logical Unit only supports audio on and audio off, the Number of Volume Levels field shall be set to 2", so they say. Paolo