From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFp6z-0007zd-BC for qemu-devel@nongnu.org; Mon, 17 Oct 2011 11:28:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RFp6r-0005w8-5K for qemu-devel@nongnu.org; Mon, 17 Oct 2011 11:28:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFp6q-0005vo-RG for qemu-devel@nongnu.org; Mon, 17 Oct 2011 11:28:13 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9HFSBlE028975 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 Oct 2011 11:28:11 -0400 Message-ID: <4E9C4989.4060100@redhat.com> Date: Mon, 17 Oct 2011 17:28:09 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1318503845-11473-1-git-send-email-pbonzini@redhat.com> <1318503845-11473-11-git-send-email-pbonzini@redhat.com> <4E9C47C0.7030306@redhat.com> In-Reply-To: <4E9C47C0.7030306@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/35] scsi-disk: support DVD profile in GET CONFIGURATION List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On 10/17/2011 05:20 PM, Kevin Wolf wrote: >> > + current = media_is_dvd(s) ? MMC_PROFILE_DVD_ROM : MMC_PROFILE_CD_ROM; >> > + memset(outbuf, 0, 40); > Is the memset required at all? I seem to remember that the output buffer > was zeroed in generic code. No, it isn't. >> > + stl_be_p(&outbuf[0], 36); /* Bytes after the data length field */ >> > + /* outbuf[4] - outbuf[19]: Feature 0 - Profile list */ > > Isn't it outbuf[8] - outbuf[19]? Right. Paolo