From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG9Qw-0007Gm-D8 for qemu-devel@nongnu.org; Tue, 18 Oct 2011 09:10:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RG9Qp-0005hC-W1 for qemu-devel@nongnu.org; Tue, 18 Oct 2011 09:10:18 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:36127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG9Qp-0005fn-K4 for qemu-devel@nongnu.org; Tue, 18 Oct 2011 09:10:11 -0400 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate01.web.de (Postfix) with ESMTP id 3FB4E19E19E5A for ; Mon, 17 Oct 2011 21:05:16 +0200 (CEST) Message-ID: <4E9C7B3C.3010703@web.de> Date: Mon, 17 Oct 2011 21:00:12 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20111017121620.GH4537@redhat.com> In-Reply-To: <20111017121620.GH4537@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigE0A29CE67D797971EF2C01BA" Subject: Re: [Qemu-devel] [RFC][PATCH 22/45] qemu-kvm: msix: Fire mask notifier on global mask changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Alex Williamson , Marcelo Tosatti , Avi Kivity , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE0A29CE67D797971EF2C01BA Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-10-17 14:16, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 11:27:56AM +0200, Jan Kiszka wrote: >> Also invoke the mask notifier if the global MSI-X mask is modified. Fo= r >> this purpose, we push the notifier call from the per-vector mask updat= e >> to the central msix_handle_mask_update. >> >> Signed-off-by: Jan Kiszka >=20 > This is a bugfix, isn't it? > If yes it should be separated and put on -stable. Yep, will pull this to the front. >=20 >> --- >> hw/msix.c | 16 +++++++++------- >> 1 files changed, 9 insertions(+), 7 deletions(-) >> >> diff --git a/hw/msix.c b/hw/msix.c >> index 739b56f..247b255 100644 >> --- a/hw/msix.c >> +++ b/hw/msix.c >> @@ -221,7 +221,15 @@ static bool msix_is_masked(PCIDevice *dev, int ve= ctor) >> =20 >> static void msix_handle_mask_update(PCIDevice *dev, int vector) >> { >> - if (!msix_is_masked(dev, vector) && msix_is_pending(dev, vector))= { >> + bool masked =3D msix_is_masked(dev, vector); >> + int ret; >> + >> + if (dev->msix_mask_notifier) { >> + ret =3D dev->msix_mask_notifier(dev, vector, >> + msix_is_masked(dev, vector)); >=20 > Use 'masked' value here as well? Yes. Jan --------------enigE0A29CE67D797971EF2C01BA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6cezwACgkQitSsb3rl5xQzMACgoRKdWA1DN6fOdsMBRATHPGAf Qv0An1aXeYIn22HD96sVHsVaIebXl2Ug =2c6c -----END PGP SIGNATURE----- --------------enigE0A29CE67D797971EF2C01BA--